Skip to content

test(mobile): repin the recording corpus to main's tip after #22381 - #22407

Merged
Jinwoo-H merged 1 commit into
mainfrom
golden-repin-996f9cc306
Sep 23, 2026
Merged

Jinwoo-H merged 1 commit into
mainfrom
golden-repin-996f9cc306

Conversation

@Jinwoo-H

@Jinwoo-H Jinwoo-H commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 0 0 0 0
Prod 788 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​788 $\color{#cf222e}{\Huge{\mathbf{−}}}$​788 0

#22381 re-recorded the bundle-fetch goldens with baseline pinned to its own branch commit, which the squash left unreachable from main, so the recording pin guard's ancestry check is red on main until this lands. This repins the corpus to main's tip 996f9cc, the tree its fenced paths match. Every golden changes only its baseline line (788 files, two distinct changed lines after masking the sha); the recorder's own reproduce check passes from the pinned tree. Same shape as #22394 after #22376.

#22381 pinned its own branch commit, which the squash left off main; the corpus now pins main at 996f9cc, the tree its fenced paths match. Every golden changes only its baseline line.

Claude-Session: https://claude.ai/code/session_01JNnE9qzUZMMnqpZWCqM3nb

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Repins the recording corpus baseline — Every golden under mobile/rpc-foundation/goldens/ and the manifest mobile/rpc-foundation/pilot-scenarios.json have their baseline line changed from the unreachable branch commit d4d6aadea298 to main's tip 996f9cc306. This is the same mechanical repin shape as #22394 after #22376.

I confirmed the diff is exactly baseline-only: 788 files, 788 insertions and 788 deletions, and after masking the sha there are only two distinct changed contents (the old and new "baseline" line) — no other +/- line exists in the corpus. No tracked reference to the old sha survives, and the new sha appears only in the goldens and the manifest. The ancestry guard passes because 996f9cc306 is an ancestor of the head/merge preview, and the changed corpus means the reproduce --if-changed-since <base> gate will run in CI (mobile.yml), replaying the corpus against the pinned tree. This is correct and unblocks --record on main.

Pullfrog  | View workflow run | Using DeepSeek Flash (free via Pullfrog for OSS) | 𝕏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant