Skip to content

docs(relay): record Roll 2 phase 0/1 (code merge, image, director deploy) - #18979

Merged
Jinwoo-H merged 1 commit into
mainfrom
relay-roll2-record
Sep 6, 2026
Merged

Jinwoo-H merged 1 commit into
mainfrom
relay-roll2-record

Conversation

@Jinwoo-H

@Jinwoo-H Jinwoo-H commented Sep 6, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 0 0 0 0
Prod 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​11 0 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​11

Operator record only: #18959 merge, image 4916ed67 publish + staging mirror, why the staging C4 smoke was dropped (#18969), director blue/green on 4916ed67 (revision 00575, rollback 00569 on 519f4914), c7 read-only verify. Continues cloud/docs/relay-reconnect-2026-09-findings.md.

@coderabbitai

coderabbitai Bot commented Sep 6, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The findings document adds a Roll 2 section. It records the merged docs-split and code changes, image publication and staging mirroring, the skipped staging-cell smoke, the successful director deployment, and the dispatched read-only c7 verify run with rollback image 85bf6799.

Merge Risk: 🟡 Moderate · up to a1e96

The Roll 2 findings currently record a conflicting c7 rollback image, which could make the deployment history operationally misleading. Resolve the image value or document the intentional exception before merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description gives a relevant summary of the documentation change, but it omits most required template sections, including ELI5, What Changed, Why, Linked Issue, Visual Proof, Testing, AI Disclosur… Complete the required sections. Add the linked issue, explain the change and reason, state N/A with a reason for Visual Proof if applicable, document testing, address review and compatibility notes, and update the checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies a documentation change and summarizes the recorded Roll 2 phases, code merge, image publication, and director deployment.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description gives a relevant summary of the documentation change, but it omits most required template sections, including ELI5, What Changed, Why, Linked Issue, Visual Proof, Testing, AI Disclosure, Review, Notes, and Checklist details.

  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 9b5ea9a8-0348-4324-8597-b20e4f60f82d

📥 Commits

Reviewing files that changed from the base of the PR and between 6031c19 and a1e96a1.

📒 Files selected for processing (1)
  • cloud/docs/relay-reconnect-2026-09-findings.md

Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.

| Image publish | run 34002233801 → `sha256:4916ed676d8389f694a648e750f1112d9002d68c84a1e0c7af828d5af129de62`; mirrored to staging (run 34002326150). | |
| Staging cell smoke | **Dropped.** Staging C4 is pinned to the Asia launch digest by `relay-staging-c4-refresh-workflow.test.mjs` (with production c27–c29 tfvars and the C4 recovery workflow) and the only C4 image-refresh path pins its accepted predecessor to an older digest. Re-pinning all of it for a smoke widens into the Asia launch machinery; #18969 closed. Roll 2 follows the Roll 1 path: director first, c7 as the rehearsal cell. | |
| Director deploy | run 34002673626 **success** 01:02Z: serving `orca-cloud-relay-00575-leq` on `4916ed67`, `00574-wag` (same image) tagged `selector-rollback`, `00569-ret` (`519f4914`) still deployable. Baseline before: 1 director Postgres retry in the prior hour, 0 `container die`. | |
| c7 `verify` (read-only) | run 34002885408 dispatched 01:03Z, target `4916ed67`, rollback `85bf6799`, protocol 1, gen 148. | |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Resolve the c7 rollback-image mismatch.

The c7 record uses rollback=85bf6799, but the Roll 2 plan and deployable rollback 00569-ret use 519f4914. Update the record or document the c7-specific exception.

Proposed correction
-| c7 `verify` (read-only) | run 34002885408 dispatched 01:03Z, target `4916ed67`, rollback `85bf6799`, protocol 1, gen 148. |
+| c7 `verify` (read-only) | run 34002885408 dispatched 01:03Z, target `4916ed67`, rollback `519f4914`, protocol 1, gen 148. |
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
| c7 `verify` (read-only) | run 34002885408 dispatched 01:03Z, target `4916ed67`, rollback `85bf6799`, protocol 1, gen 148. | |
| c7 `verify` (read-only) | run 34002885408 dispatched 01:03Z, target `4916ed67`, rollback `519f4914`, protocol 1, gen 148. | |

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Roll 2 operator record — Appends a ## Roll 2 (image 4916ed67, 2026-09-06) section to cloud/docs/relay-reconnect-2026-09-findings.md recording phase 0/1: docs split (#18958), code merge (#18959), image publish + staging mirror, the dropped staging-C4 smoke (#18969), the director blue/green deploy, and the in-flight c7 read-only verify.

Docs-only change, no behavioral surface. Content is internally consistent with the surrounding record (short image prefix 4916ed67 matches the full sha256:4916ed676d…; director revision/rollback pairs line up with the Roll 1 census).

Pullfrog  | View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) | 𝕏

@Jinwoo-H
Jinwoo-H merged commit 1326d6b into main Sep 6, 2026
25 checks passed
enrick-dev pushed a commit to enrick-dev/orca that referenced this pull request Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant