Repository navigation
Conversation
Binds cloud-deploy-relay-staging to 4916ed67 (main 61b09b7: per-cell inventory locks, statement timeout, accept abandonment, 6h control lease) so the director and cell smoke run on the image Roll 2 will ship.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughUpdated the pinned relay container image digest for the Merge Risk: ⚪ Minimal · up to This updates the staging relay cell to the Roll 2 pinned image so staging deployment and smoke tests use the upcoming relay build. No current merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description explains the image digest change and its purpose, but it omits most required template sections, including Why, Linked Issue, Visual Proof, Testing, AI Disclosure, Review, Agent skill upstream boundary, Notes, and Checklist. Resolution Add all required template sections. Include a linked issue with a valid issue number, state N/A with a reason for Visual Proof, document testing or explain why tests are not needed, complete the applicable checkboxes, and address the remaining review and compatibility sections.
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Important
Pinning the staging c4 image without updating the source-text test that pins it will fail cloud CI.
Reviewed changes
- Pin staging
c4to the Roll 2 image — updatesrelay_gce_cells["staging-gce-c4"].imageincloud/infra/terraform/environments/staging.tfvarsfrom5aedbca5…to4916ed67…(the Roll 2 digest built from main61b09b7a02).
⚠️ relay-staging-c4-refresh-workflow.test.mjs still pins c4 to the previous digest
cloud/dev/scripts/relay-staging-c4-refresh-workflow.test.mjs (test "pins staging C4 and all production Asia cells to the same launch image") reads staging.tfvars and asserts staging-gce-c4's image equals relay@sha256:5aedbca5… via the launchDigest constant. This PR moves c4 to 4916ed67…, so that assertion fails and cloud CI goes red — cloud-verify.yml's test job runs pnpm test, which includes this file. Verified locally: node --test cloud/dev/scripts/relay-staging-c4-refresh-workflow.test.mjs fails with the c4 image mismatch. The production-Asia (c27–c29) and recovery-workflow assertions in the same test still pass.
Technical details
# Update the c4 pin test to match the Roll 2 image
## Affected sites
- cloud/dev/scripts/relay-staging-c4-refresh-workflow.test.mjs:36 — `launchDigest` = `5aedbca5…`
- cloud/dev/scripts/relay-staging-c4-refresh-workflow.test.mjs:52 — asserts staging c4 image == `launchDigest`
- cloud/infra/terraform/environments/staging.tfvars:76 — new digest `4916ed67…`
## Required outcome
- Cloud CI green. The staging-c4 assertion must reflect the intentional divergence
(staging c4 ahead of production Asia for the Roll 2 staging test) without dropping the
production-Asia and recovery-workflow assertions that still hold.
## Suggested approach (optional)
- Give the staging c4 assertion its own expected digest (`4916ed67…`) instead of sharing
`launchDigest` with the production-Asia cells, and update the test name/comment that
describes them as "the same launch image".DeepSeek Pro (free via Pullfrog for OSS) | 𝕏
|
Closing: |

ELI5
Before the next production relay roll, we run the new relay build on the staging copy first. This points staging's test cell at that build so the staging deploy workflow accepts it.
Change
staging-gce-c4image digest5aedbca5…→4916ed67…(built from main61b09b7a02, the #18959 merge). Roll 2 image contents: per-cell inventory locks + pool statement timeout (#18722), accept abandonment + 6 h control lease + mobile probe fail-fast (#18959),--private-ipproxy support (#18720, flag unset).tfvars only. The staging director deploy (
cloud-deploy-relay-staging) binds its digest input to this value. Plan:cloud/docs/relay-roll2-plan-2026-09.mdPhase 1.