Skip to content

chore(cloud): pin staging relay c4 to the Roll 2 image - #18969

Closed
Jinwoo-H wants to merge 1 commit into
mainfrom
relay-staging-c4-roll2-image
Closed

Jinwoo-H wants to merge 1 commit into
mainfrom
relay-staging-c4-roll2-image

Conversation

@Jinwoo-H

@Jinwoo-H Jinwoo-H commented Sep 6, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 0 0 0 0
Prod 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​1 $\color{#cf222e}{\Huge{\mathbf{−}}}$​1 0

ELI5

Before the next production relay roll, we run the new relay build on the staging copy first. This points staging's test cell at that build so the staging deploy workflow accepts it.

Change

staging-gce-c4 image digest 5aedbca5… → 4916ed67… (built from main 61b09b7a02, the #18959 merge). Roll 2 image contents: per-cell inventory locks + pool statement timeout (#18722), accept abandonment + 6 h control lease + mobile probe fail-fast (#18959), --private-ip proxy support (#18720, flag unset).

tfvars only. The staging director deploy (cloud-deploy-relay-staging) binds its digest input to this value. Plan: cloud/docs/relay-roll2-plan-2026-09.md Phase 1.

Binds cloud-deploy-relay-staging to 4916ed67 (main 61b09b7: per-cell
inventory locks, statement timeout, accept abandonment, 6h control lease)
so the director and cell smoke run on the image Roll 2 will ship.
@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 566c26e6-dd0f-4fff-a4d2-9563d6aabe1c

📥 Commits

Reviewing files that changed from the base of the PR and between b6ca8da and 9731a60.

📒 Files selected for processing (1)
  • cloud/infra/terraform/environments/staging.tfvars

Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

Updated the pinned relay container image digest for the staging-gce-c4 cell in the staging Terraform variables.

Merge Risk: ⚪ Minimal · up to 9731a

This updates the staging relay cell to the Roll 2 pinned image so staging deployment and smoke tests use the upcoming relay build. No current merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the image digest change and its purpose, but it omits most required template sections, including Why, Linked Issue, Visual Proof, Testing, AI Disclosure, Review, Agent skill u… Add all required template sections. Include a linked issue with a valid issue number, state N/A with a reason for Visual Proof, document testing or explain why tests are not needed, complete the applicable checkboxes, and address the remain…
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the staging relay image pinning change and matches the primary change in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the image digest change and its purpose, but it omits most required template sections, including Why, Linked Issue, Visual Proof, Testing, AI Disclosure, Review, Agent skill upstream boundary, Notes, and Checklist.

Resolution

Add all required template sections. Include a linked issue with a valid issue number, state N/A with a reason for Visual Proof, document testing or explain why tests are not needed, complete the applicable checkboxes, and address the remaining review and compatibility sections.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Pinning the staging c4 image without updating the source-text test that pins it will fail cloud CI.

Reviewed changes

  • Pin staging c4 to the Roll 2 image — updates relay_gce_cells["staging-gce-c4"].image in cloud/infra/terraform/environments/staging.tfvars from 5aedbca5… to 4916ed67… (the Roll 2 digest built from main 61b09b7a02).

⚠️ relay-staging-c4-refresh-workflow.test.mjs still pins c4 to the previous digest

cloud/dev/scripts/relay-staging-c4-refresh-workflow.test.mjs (test "pins staging C4 and all production Asia cells to the same launch image") reads staging.tfvars and asserts staging-gce-c4's image equals relay@sha256:5aedbca5… via the launchDigest constant. This PR moves c4 to 4916ed67…, so that assertion fails and cloud CI goes red — cloud-verify.yml's test job runs pnpm test, which includes this file. Verified locally: node --test cloud/dev/scripts/relay-staging-c4-refresh-workflow.test.mjs fails with the c4 image mismatch. The production-Asia (c27–c29) and recovery-workflow assertions in the same test still pass.

Technical details
# Update the c4 pin test to match the Roll 2 image

## Affected sites
- cloud/dev/scripts/relay-staging-c4-refresh-workflow.test.mjs:36 — `launchDigest` = `5aedbca5…`
- cloud/dev/scripts/relay-staging-c4-refresh-workflow.test.mjs:52 — asserts staging c4 image == `launchDigest`
- cloud/infra/terraform/environments/staging.tfvars:76 — new digest `4916ed67…`

## Required outcome
- Cloud CI green. The staging-c4 assertion must reflect the intentional divergence
  (staging c4 ahead of production Asia for the Roll 2 staging test) without dropping the
  production-Asia and recovery-workflow assertions that still hold.

## Suggested approach (optional)
- Give the staging c4 assertion its own expected digest (`4916ed67…`) instead of sharing
  `launchDigest` with the production-Asia cells, and update the test name/comment that
  describes them as "the same launch image".

Pullfrog  | Fix it ➔ | View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) | 𝕏

@Jinwoo-H

Jinwoo-H commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

Closing: relay-staging-c4-refresh-workflow.test.mjs pins staging C4, production c27–c29 tfvars, and the C4 recovery workflow to one launch image on purpose, and the only C4 image-refresh path (refresh-asia-c4-image) pins its accepted predecessor to an older digest. Re-pinning all of that for a staging smoke widens scope into the Asia launch machinery. Roll 2 follows the Roll 1 path instead: director blue/green, then the c7 canary as the rehearsal cell. Recorded in the Roll 2 plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant