Repository navigation
docs(mobile): add Android APK install guidance - #14978
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan includes up to 10 reviews per rolling hour; 7 remain after this review. 📝 WalkthroughWalkthroughAdds an Android installation guide URL and a shell action that opens it in the system browser. Propagates the action through 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/renderer/src/components/mobile/MobileHero.test.tsx (1)
75-75: 🎯 Functional Correctness | 🔵 Trivial | 💤 Low valueThe test correctly verifies the "Install guide" button invokes
onOpenAndroidInstallGuideonce. The addedscreen.queryByText(/full browser, not an in-app browser/)check asserts absence of text that does not appear anywhere inMobileAndroidInstallHelpor the surrounding render tree, so it always passes trivially and adds limited verification value. This does not block the change.Also applies to: 123-123, 158-171
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: c53ef589-2485-4f86-a7e6-32a830d0de4b
📒 Files selected for processing (10)
README.mdsrc/renderer/src/components/mobile/MobileAndroidInstallHelp.tsxsrc/renderer/src/components/mobile/MobileHero.test.tsxsrc/renderer/src/components/mobile/MobileHero.tsxsrc/renderer/src/components/mobile/MobilePage.test.tsxsrc/renderer/src/components/mobile/MobilePage.tsxsrc/renderer/src/components/mobile/MobilePageContent.tsxsrc/renderer/src/components/mobile/mobile-platform-copy.tssrc/renderer/src/components/mobile/use-mobile-install-actions.tssrc/renderer/src/i18n/locales/en.json
Included review availability: Your plan includes up to 10 reviews per rolling hour; 9 remain after this review.
…7) (stablyai#15566) Taken from stablyai#15396. Matches the English README's install-guide link added in stablyai#14978. Fixes stablyai#15395 Co-authored-by: m4air <m4air@m4airs-Air.localdomain> Co-authored-by: erishforG <eric.signal@kakaocorp.com>
…7) (stablyai#15566) Taken from stablyai#15396. Matches the English README's install-guide link added in stablyai#14978. Fixes stablyai#15395 Co-authored-by: m4air <m4air@m4airs-Air.localdomain> Co-authored-by: erishforG <eric.signal@kakaocorp.com>
Summary
The canonical full guide is in stablyai/orca-marketing-website#244, because onorca.dev docs are sourced from that repository.
Evidence
The STA-4498 screenshot is an Android Custom Tab stuck at
133.02 MB / 133.02 MB; the current GitHub release asset is exactly 133,018,667 bytes and returns HTTP 200. The APK itself parses as Android 7.0+ and includes ARM32, ARM64, x86, and x86_64 libraries, so the reported state precedes package installation and does not indicate an Orca download-backend or ABI failure.Validation so far
pnpm exec vitest run --config config/vitest.config.ts src/renderer/src/components/mobile/MobileHero.test.tsx src/renderer/src/components/mobile/MobilePage.test.tsx(31 tests)pnpm typecheckVisual validation and independent review remain in progress while this PR is draft.
Closes #14827. Tracks STA-4498.