Skip to content

fix(mobile): pin Android APK download to current release - #13166

Closed
bbingz wants to merge 3 commits into
stablyai:mainfrom
bbingz:fix/11444-android-download-guidance
Closed

bbingz wants to merge 3 commits into
stablyai:mainfrom
bbingz:fix/11444-android-download-guidance

Conversation

@bbingz

@bbingz bbingz commented Aug 8, 2026 •

Copy link
Copy Markdown
Contributor

ELI5

Android downloads can occasionally stall near completion. Orca now tells users how to recover by downloading the APK on a computer and transferring it to the phone, while keeping every renderer install entry pointed at one verified release URL.

What Changed

  • Share one Android APK URL between the Mobile page and Settings instead of maintaining two renderer literals.
  • Pin that shared URL to the published mobile-android-v0.0.43 release.
  • Add a short Settings fallback for downloads stuck near 99%: use a computer, then transfer by USB cable, cloud storage, or messaging.
  • Add focused tests for the published URL and the rendered fallback guidance.
  • Drop the original translated README edits from this PR because Update mobile 0.0.43 Android download links #14696 already updated them to 0.0.43 on main.

Why

#11444 describes an external browser/OS download failure that Orca cannot repair directly. A visible alternative install path prevents that failure from blocking onboarding. Sharing the renderer URL also prevents Mobile and Settings from drifting during future release updates.

Linked Issue

Fixes #11444

Visual Proof

Not captured locally: this session does not provide the repository-required $electron validation skill. The copy is covered by a happy-dom rendering test; no screenshot is claimed.

Testing

  • Automated tests added.
  • RED: without the fallback paragraph, the rendering test failed because the guidance was absent.
  • GREEN: mobile-platform-copy.test.ts and MobileSettingsPane.test.tsx — 2 files, 2 tests passed.
  • Published asset probe: mobile-android-v0.0.43/app-release.apk returned HTTP 200.
  • pnpm typecheck
  • pnpm lint, including localization catalog, extraction, and coverage checks.
  • pnpm run check:code-quality:changed — 0 findings across 4 code files.
  • pnpm exec oxfmt --check on all 5 changed files.
  • Full pnpm test, pnpm build, and rendered Electron screenshot were not run locally.

AI Disclosure

Codex (GPT-5) was used to refresh the branch, migrate the release tag, add regression coverage, and review the final diff.

Review

Please focus on whether Settings is the right surface for the recovery guidance and whether the shared renderer URL fits the Android release-update workflow.

Agent skill upstream boundary

  • Not applicable; this change does not copy or translate agent skill-installer material.

Notes

  • Cross-platform: the guidance uses Android-compatible transfer choices and intentionally does not mention AirDrop.
  • Remote/SSH, mobile wire compatibility, and provider behavior are unchanged.
  • The URL is a static published release asset, matching the repository's current release-link policy.

Checklist

  • This PR is small and focused
  • I explained what changed and why (including ELI5)
  • Before/after screenshot was not captured; the limitation is documented above
  • Self-reviewed for correctness, security, and performance
  • Cross-platform and mobile impact considered
  • Full pnpm test and pnpm build were not run locally; focused tests and CI cover the change.

Author

@coderabbitai

coderabbitai Bot commented Aug 8, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8a11d215-7db5-4faf-a617-c8c269a94ae5

📥 Commits

Reviewing files that changed from the base of the PR and between e4e54a1 and ba058a3.

📒 Files selected for processing (5)
  • src/renderer/src/components/mobile/mobile-platform-copy.test.ts
  • src/renderer/src/components/mobile/mobile-platform-copy.ts
  • src/renderer/src/components/settings/MobileSettingsPane.test.tsx
  • src/renderer/src/components/settings/MobileSettingsPane.tsx
  • src/renderer/src/i18n/locales/en.json
🚧 Files skipped from review as they are similar to previous changes (5)
  • src/renderer/src/components/settings/MobileSettingsPane.tsx
  • src/renderer/src/components/mobile/mobile-platform-copy.test.ts
  • src/renderer/src/components/mobile/mobile-platform-copy.ts
  • src/renderer/src/i18n/locales/en.json
  • src/renderer/src/components/settings/MobileSettingsPane.test.tsx

Included review availability: Your plan includes up to 10 reviews per rolling hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The Android APK release tag is pinned to mobile-android-v0.0.43, and the shared download URL is derived from that tag. Android install-copy tests verify the tag, URL, and stable platform output. Mobile settings now imports the shared URL and displays translated instructions for stalled downloads. A component test verifies the fallback message.

Merge Risk: ⚪ Minimal · up to ba058

This localized change pins Android downloads to the current release and adds recovery guidance for stalled downloads; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: pinning the Android APK download to the current release.
Description check ✅ Passed The description covers the change, rationale, linked issue, testing, limitations, AI use, and scope with only the required visual proof missing.
Linked Issues check ✅ Passed The PR addresses issue #11444 by adding desktop-download and transfer guidance for Android downloads that stall near 99%.
Out of Scope Changes check ✅ Passed The changed files support the linked issue through URL centralization, release pinning, fallback guidance, and focused tests.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
src/renderer/src/components/mobile/mobile-platform-copy.test.ts (1)

9-12: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Assert the complete APK URL.

The test only checks that the URL contains the release tag and that getInstallCopy() returns the same exported constant. It would pass if the repository path or APK filename were wrong. Assert the complete expected URL.

Proposed test adjustment
     expect(ORCA_ANDROID_APK_RELEASE_TAG).toBe('mobile-android-v0.0.37')
-    expect(ORCA_ANDROID_APK_URL).toContain(ORCA_ANDROID_APK_RELEASE_TAG)
-    expect(getInstallCopy('android', 'stable').url).toBe(ORCA_ANDROID_APK_URL)
+    const expectedUrl =
+      'https://github.com/stablyai/orca/releases/download/mobile-android-v0.0.37/app-release.apk'
+    expect(ORCA_ANDROID_APK_URL).toBe(expectedUrl)
+    expect(getInstallCopy('android', 'stable').url).toBe(expectedUrl)

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 24b7ab9a-20ef-4b06-9782-865a6f2ca8f1

📥 Commits

Reviewing files that changed from the base of the PR and between 9825706 and 538c7c32e29c44730e0ddf34bba9d3d20cb0ace7.

📒 Files selected for processing (9)
  • docs/readme/README.es.md
  • docs/readme/README.fr.md
  • docs/readme/README.ja.md
  • docs/readme/README.ko.md
  • docs/readme/README.pt.md
  • docs/readme/README.zh-CN.md
  • src/renderer/src/components/mobile/mobile-platform-copy.test.ts
  • src/renderer/src/components/mobile/mobile-platform-copy.ts
  • src/renderer/src/components/settings/MobileSettingsPane.tsx

@AmethystLiang
AmethystLiang requested a review from OrcaWin August 9, 2026 16:52
@bbingz
bbingz force-pushed the fix/11444-android-download-guidance branch from 538c7c3 to 4554d35 Compare August 11, 2026 05:01
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

Settings and mobile install copy still linked mobile-android-v0.0.32
while README shipped 0.0.37, and phone browsers often stall near 99%
with no recovery hint. Point UI/docs at the current APK tag and document
the desktop-transfer workaround for stuck downloads.

Closes stablyai#11444
@bbingz
bbingz force-pushed the fix/11444-android-download-guidance branch from 4554d35 to 4a57315 Compare August 13, 2026 03:01
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@bbingz
bbingz requested a review from brennanb2025 as a code owner August 16, 2026 13:53
@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@bbingz

bbingz commented Aug 16, 2026

Copy link
Copy Markdown
Contributor Author

Refreshed onto current origin/main without a force push.

Head ba058a3e56005817c9167cda67fce5e7b3ee6f9e now differs from main by 5 focused files only:

  • shared renderer APK URL pinned to published Android 0.0.43
  • Settings fallback guidance for downloads stalled near 99%
  • exact URL and rendered-copy regressions

The six translated README changes were removed because #14696 already landed the 0.0.43 links.

Verification:

  • RED observed with fallback paragraph removed
  • 2 focused test files / 2 tests passed
  • APK asset HTTP 200
  • pnpm typecheck, pnpm lint, and format checks passed
  • changed-code quality: 0 findings across 4 code files

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 16, 2026 •

Copy link
Copy Markdown
Contributor

@bbingz: I will review the refreshed pull request, including the APK URL centralization, Settings fallback guidance, and focused regression tests.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@bbingz

bbingz commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Closing: both halves have been handled on main, by a different route.

The APK link pinning landed via #14696 / #13565 — mobile-platform-copy.ts and MobileSettingsPane.tsx:15-16 both point at mobile-android-v0.0.43/app-release.apk already.

For the "stuck at 99%" copy, 19ba83d496 (#14978) chose an external doc instead: it adds ANDROID_INSTALL_GUIDE_URL and MobileAndroidInstallHelp.tsx, and MobileHero.test.tsx explicitly asserts the app opens the APK install guide without duplicating its troubleshooting steps. Adding that copy in-app would contradict that decision.

Closing to keep my open-PR queue honest. If this turns out to be wrong I'll reopen — please just say so, or reopen it yourself, within the next 7 days.

@bbingz bbingz closed this Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: Android direct-download often stalls at 99% — make install path more resilient

3 participants