Skip to content

[Feature]: Support ACP form elicitation so OMP sessions started in the chat UI get the ask tool #26924

Closed

Description

@jairuspace

Problem or use case

When an OMP (Oh My Pi) session starts directly in Orca's chat UI, OMP has no ask tool. The model can't ask a structured question with options. It falls back to asking in plain text, or it guesses.

The same OMP version has ask when it's started in a terminal and switched to the chat view. After #26688, Orca's question card answers that dialog correctly.

Why it happens:

  • Orca starts chat-UI OMP sessions as omp acp (src/main/acp/acp-launch-specs.ts). OMP and Orca then talk over ACP, the Agent Client Protocol.
  • Over ACP, OMP only enables ask when the client advertises form elicitation: clientCapabilities.elicitation.form. OMP 18.8.6 checks this in packages/coding-agent/src/modes/acp/acp-agent.ts (interactivePrompts: clientCapabilities?.elicitation?.form != null), and tools/ask.ts only creates the tool when canPromptUser is true.
  • Orca's ACP client initializes with clientCapabilities: { fs: { readTextFile: false, writeTextFile: false }, terminal: false } (src/main/acp/acp-session-runtime.ts). It never advertises elicitation, so OMP leaves ask out. OMP's other prompts over ACP (select, confirm, input, plan approval) are skipped or auto-approved the same way.

Orca already avoids question tools in ACP sessions on purpose: for OpenCode it sets OPENCODE_ENABLE_QUESTION_TOOL: 'false' because ACP "cannot answer (it would wait forever)". So this asks for a new capability, not a fix to a regression.

Proposed solution

Support ACP form elicitation in Orca's ACP client, and turn it on for agents that use it (OMP first):

  1. Advertise elicitation: { form: {} } in initialize for agents whose ACP mode supports it.
  2. Handle the agent's form-elicitation requests: a message plus a JSON-schema-like set of properties.
    • OMP's ask maps each question to a property: a string enum for single choice, an array for multi-select, and an optional <key>__other string for "Other (type your own)".
    • OMP's simpler select / confirm / input prompts use the same request.
  3. Render the request with the existing native-chat question card (NativeChatQuestionCard), and send the user's choices back as structured content (accept, decline or cancel).
  4. Keep a timeout and cancellation story. OMP aborts the request when its own timeout or abort signal fires. Orca's card should go away when that happens, and a late answer should be dropped.

This answers with structured data rather than keystrokes, which avoids the cursor-navigation timing that terminal sessions need.

Alternatives or additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions