Skip to content

[Bug]: Chat view: answering an OMP ask question picks the wrong option or hangs OMP #26692

Closed

Description

@jairuspace

Operating system

macOS

Orca version

v1.4.222

Details

Short summary:
When OMP (Oh My Pi) asks a question with its ask tool and the session is open in Orca's chat view, answering the question card doesn't answer it in OMP. Depending on the question, OMP gets the wrong option or never gets an answer, and the card stays open.

What happened?

  • Single question: OMP received the highlighted row (its recommended option, or the first one), not the option I clicked.
  • Several questions: OMP's dialog never submitted. Question 1 got its highlighted row, the dialog sat on question 2, OMP hung waiting for an answer, and the chat card stayed open.
  • A lone multi-select question: the Enter confirmed an empty selection, so OMP recorded the question as cancelled by the user.
  • Multi-select questions showed up as single-select cards.

How can we reproduce it?

  1. Start an OMP session in Orca and switch it to the chat view.
  2. Get OMP to ask a question with the ask tool. Use two or more questions to reproduce the hang.
  3. Answer it in the chat card.

Anything else that might help:
Orca answers an OMP question the way it sends a chat message: it pastes the answer text and presses Enter. OMP's ask dialog is moved with the arrow keys, has no number shortcuts, and ignores pasted text. The paste does nothing, and the Enter acts on whatever row is highlighted. On a prompt with several questions, that Enter answers only the first question with its highlighted row, and the dialog then waits on question 2.

OMP also marks multi-select questions with multi: true, but Orca only reads multiSelect.

OMP versions: the tabbed ask dialog behaves the same from OMP 18.2.0 through 18.8.7. Up/Down move, Enter selects a single-select row, Space toggles a multi-select row, Enter on a multi-select row confirms and moves on, and submitting "Other" moves on by itself. OMP 17.x and 18.0.x differ on multi-select. Also reported on OMP 18.6.1 and Orca 1.4.220 on Windows and mobile in #26198.

Correction: an earlier version of this issue said the analysis was checked against OMP 18.8.6. It was actually checked against a stale 17.2.12 copy of OMP's source. The version details above come from OMP's tagged source for each release.

Activity

  1. changed the title [-]Chat view: answering an OMP ask question picks the wrong option or hangs OMP[/-] [+][Bug]: Chat view: answering an OMP ask question picks the wrong option or hangs OMP[/+] on Oct 8, 2026
  2. shryu1994 commented on Oct 9, 2026

    @shryu1994

    Also hitting this from the Orca mobile app: Orca 1.4.222 (macOS desktop) with OMP 18.8.6.

    In a 5-question ask, the mobile card answered question 1 with its (Recommended) row, not the row I tapped. The dialog then sat on question 2, and no tool result was recorded. A single-question ask got through, but always with the recommended row.

    A concern about the multi-select key plan in #26688. In OMP 18.8.6, Enter on a multi-select row does not toggle it. Space toggles. Enter confirms the current set and advances. In a single-question dialog, Enter submits right away.

    • packages/tui/src/overlays/ask-dialog.ts (v18.8.6), #commitRow: if (question.multi) { if (isEnter) { this.#advanceAfterQuestion(); return; } …toggle… }
    • #advanceAfterQuestion(): a single-question dialog calls #finishSubmit().
    • OMP's own tests cover this: packages/tui/test/ask-dialog.test.ts, "multi-select: Space toggles options; Enter submits the current selection" and "multi-select: Enter submits an empty selection instead of dead-ending".

    Here is what the current buildOmpAskAnswerKeys would do on 18.8.6, from reading the source. I have not run the PR.

    • Single multi-select question, picks A + C: the first Up×n, Down×0, Enter submits an empty selection. The later keys reach the composer after the dialog closes.
    • Multi-select question followed by more questions: the first Enter advances to the next question with nothing checked. The rest of that question's picks then land on the following question.

    A plan that matches 18.8.6 for a multi-select question:

    1. For each pick: Up×rows, Down×i, Space.
    2. If there is free text: go to the Other row, Enter, paste, Enter. OMP then advances by itself; in a single-question dialog it moves to the Review tab.
    3. If there is no free text: one Enter to advance. A single-question dialog submits here, so no trailing Enter.
    4. A final Enter on the Review tab, only when the dialog actually ends on Review: more than one question, or a single multi-select question answered with Other.

    Right/Tab also wraps on the Review tab (#switchTab uses modulo), so an extra ASK_NEXT_TAB there moves back to question 1 instead of staying put.

  3. nwparker commented on Oct 9, 2026

    @nwparker
    Contributor

    Consolidating #26198 here because both reports describe the same OMP ask-card delivery failure on desktop and mobile: Orca pastes option labels instead of navigating OMP's selector, so the highlighted/recommended answer is submitted and later questions remain blocked. Keeping this issue as the canonical report because it already has the newer OMP 18.8.6 details and active fix PR #26688. This is consolidation, not a claim that the bug is fixed; that PR is still open and current main still excludes OMP from shouldStepNativeChatAskAnswer.

    Please retain the older report's regression details:

    • [Bug]: Native chat: answering an omp ask card always submits the highlighted (recommended) option #26198 reproduced this on Orca 1.4.220 / OMP 18.6.1 on Windows desktop and mobile, despite its template saying macOS.
    • Its 18.6.1 HookSelector starts at the recommended row, ignores pasted labels for ordinary menus, and uses sequential question selectors. Navigation must not assume row zero.
    • Its legacy multi-select uses Enter to toggle and Done/Right to advance; its free-text Other row opens an editor. Some of those legacy paths were source-inspected rather than tested live.
    • The 18.8.6 ask-dialog behavior documented above differs: Space toggles, Enter advances/submits, and Review is conditional. Do not apply the old 18.6.1 keystroke plan unchanged to 18.8.6.

    The original reproduction and version-specific analysis remain available in #26198. Verification should cover non-recommended choices, multiple questions, multi-select, and Other/free text on both desktop and mobile, with the supported OMP versions made explicit.

  4. AmethystLiang commented on Oct 9, 2026

    @AmethystLiang
    Contributor

    Thanks for reporting. Looking into it

  5. jairuspace commented on Oct 9, 2026

    @jairuspace
    ContributorAuthor

    @shryu1994 thanks, you're right. My earlier check loaded a stale 17.2.12 copy of OMP's source, and Enter does toggle a multi-select row in 17.x. In 18.x, Space toggles and Enter confirms and moves on. #26688 now does this for each multi-select question:

    1. Space on each picked row, moving to it with Up × options and then Down × index.
    2. If there's free text: the Other row, Enter, paste, Enter, and nothing after that, because OMP moves on by itself.
    3. Otherwise Right to move on. I used Right rather than Enter because it moves on from any row, while Enter on the Other row would open its editor, and Right also works on 17.x and 18.0.x.
    4. A final Enter only when the dialog ends on Review: more than one question, or any multi-select question. Every path above lands on Review in exactly those cases, so it never wraps the way you described.

    @nwparker thanks for consolidating #26198. Here's the version picture from OMP's tagged source. OMP 18.6.1's interactive TUI already uses the tabbed AskDialogComponent. The sequential HookSelector path in #26198 is only the fallback when no askDialog UI is available, and the selection logic is identical in 18.6.1 and 18.8.6.

    OMP Multi-select "Other" on a multi-select
    17.x Enter or Space toggles stays on the question
    18.0.x Space toggles, Enter moves on stays on the question
    18.2.0 – 18.8.7 Space toggles, Enter moves on moves on by itself

    Supported: OMP ≥ 18.2.0. Single-select also works on 17.x.

    I checked this against what OMP itself returns:

    • Real omp 18.8.6 binary in a terminal, with no model: an extension command opens the same askDialog and writes OMP's result. All 11 scenarios pass:
      • a pick that isn't the recommended row
      • your 5-question case
      • a skipped question
      • a lone multi-select
      • multi-select, then a single-select
      • multi-select + Other, alone and before another question
      • leftover one- and three-line text in OMP's input box, which is cleared first and never sent
    • Each version's own dialog code from npm:
    OMP Scenarios passing
    18.8.7 11/11
    18.8.6 11/11
    18.6.1 11/11
    18.2.0 11/11
    17.2.12 9/11: only multi-select + Other, as expected
    • Mobile: a new test checks that the phone sends OMP's key groups one at a time, paced, and never pastes the label. Mobile typecheck, lint and tests pass.

    I haven't yet done a live run through the Orca chat card with a real model, on desktop and on the phone. I'll post the results on the PR.

  6. nwparker commented on Oct 21, 2026

    @nwparker
    Contributor

    I’m working on this as part of the second mobile bug-fix batch. I’ll reproduce the current behavior, review community PR #29184, and prepare a fix with contributor credit, native mobile emulator validation, and before/after visual evidence. I’ll link the resulting PR and call out any validation limitations here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

os:macosIssues affecting macOS

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions