Repository navigation
runtime options: judge CICS region / program-definition values for syntax (Part of #4707) - #6192
Merged
Merged
Conversation
…ntax (Part of #4707) LOCALCCSID, DB2CONN, CICS_TS, CONCURRENCY and EXECKEY are checked against what IBM accepts; a value outside it is refused by name, once, instead of being declared as a code page. runtime_effect now reports a recorded-only row as refused when its value is not that row's syntax. No burned estate cell moves. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
squid-protocol
added
the
shepherd:merge
Owner
Author
|
No description provided. |
squid-protocol
marked this pull request as ready for review
October 23, 2026 08:24
squid-protocol
enabled auto-merge (squash)
October 23, 2026 08:26
Contributor
Owner
Author
|
No description provided. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4707 (CICS slice; follows #6182).
What
CICS_OPTIONSingitgalaxy/core/runtime_options.pyjudges the CICS region and program-definition values for syntax, same pattern asLE_OPTIONS/DB2_OPTIONS:region.LOCALCCSID(1-5 digits, not zero),region.DB2CONN(YES/NO),region.CICS_TS(release number),program_definition.CONCURRENCY(QUASIRENT/THREADSAFE/REQUIRED),program_definition.EXECKEY(USER/CICS). A value outside the syntax is refused by name, once; a well-formed one keeps its outcome (LOCALCCSID 37/1140 honoured, other CCSID declared).runtime_effectnow reports "refused" for a recorded-only row whose value is not its syntax (it returned "no effect" before the check ran).Register C18 gains the rendered table; tests mirror the Db2 set.
Facts checked
037,YES,4.2,THREADSAFE) is well-formed: test over all estate option files; no cell moves. No parsing code touched, so no golden re-bless.audit_check.py: ruff/format, mypy, dead-key, ast-accuracy all clear.test_runtime_option_table.py: 253 passed.Sibling gaps
cics.translator.optionsalready judged per token;cics.convention.*are conventions, not option values. No burned program needs any further CICS option row.Lessons for agents
runtime_effectshort-circuited onpolicy None, so a syntax-judged recorded-only row could never read "refused"; check the row's hits first.Cross-repo: none.
🤖 Generated with Claude Code