Repository navigation
XCTL of a value field of the LINKed DTO is refused by name (X39, Part of #5060) - #5332
Merged
Merged
Conversation
… of #5060) CicsTask traced the LINK caller's storage by reference, so a String or number DTO field passed as the XCTL COMMAREA slipped through. A value equal to one the DTO holds (any depth, primitives included) is now refused with the X39 message; an equal-valued copy is over-refused (refuse, never guess). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Owner
Author
|
No description provided. |
squid-protocol
marked this pull request as ready for review
October 17, 2026 11:52
Owner
Author
|
CI shepherd: the head of this PR (fd62b62) is not the one a maintainer labelled |
Owner
Author
|
No description provided. |
squid-protocol
enabled auto-merge (squash)
October 17, 2026 12:04
Owner
Author
|
No description provided. |
Contributor
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5060 (first checkbox: model-port scalar fields).
Class: XCTL of storage a LINK caller owns (X39), model-port path.
CicsTask.xctltraced the caller's DTO by reference only; a String/number field passed as the COMMAREA is a value and was not refused.Change: for a program LINKed with a DTO, a non-null COMMAREA that equals a value held anywhere in the DTO graph (nested groups, tables, lists, map values, primitive/boxed fields) is refused with the existing X39 message. An equal-valued copy is over-refused (cannot be told apart; refuse, never guess). Template-only change in
CICS_TASK_JAVA; register X39 "Model ports" updated.Tests:
test_model_link_xctl_4956.pyflipsnameto REFUSED and adds number / nested / table-element / map-value (refused) plus distinct value and null COMMAREA (not refused). Ran with the 4816/4957 XCTL tests (16 passed) andtests/cics_crucible/test_cics_runtimes.py(206 passed).Not run:
det_port.py check(which ports moved),pr_gates, golden bless; mypy missing in this venv.Sibling gaps: copy vs same storage needs a real z/OS run (stays REFUSED, not churn). No burned-estate program known to need either; not grepped.
Cross-repo: none. Overlaps open PR #5328 on
cobol_to_java_transaction_forge.py; origin/main merged in, diff kept small.Lessons for agents
sleep N && catis blocked; background the run and use Monitor with an until-loop.🤖 Generated with Claude Code