Repository navigation
det: repeated 01 FILLER groups translate; zECS ZECS001 no longer refused whole (Part of #4767) - #5214
Merged
Merged
Conversation
…01 translates (Part of #4767) ZECS001 declares 01 FILLER four times, each with named children. Nothing can name a FILLER, so the #4952 duplicate-01 refusal does not apply. The second and later ones take a line-suffixed storage name; the first keeps s_FILLER, so no existing port moves (det_port check: 112/112 unchanged). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
squid-protocol
added
the
shepherd:merge
Owner
Author
|
No description provided. |
squid-protocol
marked this pull request as ready for review
October 15, 2026 21:45
squid-protocol
enabled auto-merge (squash)
October 15, 2026 21:51
Owner
Author
|
No description provided. |
Contributor
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4767.
Design status: the WEB family design and slices are already on main (X35 client #4877, X36/X37 #4898, X38 #4938/#5026, X41 #4989/#5036, pointer lane X47). This PR is the residual the zECS re-survey found.
Cause:
det_surveyon zECS showed ZECS001 not translating at all:a second 01 group named FILLER(the #4952 duplicate-01 refusal). ZECS001 declares01 FILLER.four times with named children. Nothing can name a FILLER, so unlike a repeated real name nothing is ambiguous.Fix: the second and later
01 FILLERtake a line-suffixed storage name (Item.storage_alias); the first keepss_FILLER. A repeated real-named group is still refused.Result: ZECS001 549/561 translated and compiles. Left holes are not WEB: pointer arithmetic over REDEFINES (#5042), ADDRESS OF a non-LINKAGE item, CALL ZUIDSTCK (#4771).
Gates:
pr_gates --fast6/6,--ratchets8/8,det_port.py check112/112 unchanged. New test:test_repeated_01_filler_groups_each_get_their_own_storage(translate plus a Java run).Cross-repo: none. cics-crucible C3-C5 cases are separate work in that repo.
🤖 Generated with Claude Code