Repository navigation
evidence report: every-number check vs options provenance - #4797
Merged
Merged
Conversation
The summary line printed programs - stale, a number report.json does not hold, so test_every_number_in_the_markdown_comes_from_the_json failed on main as soon as a refresh left one carddemo program stale (44 - 1 = 43; it only passed before by coincidence or with 0 stale). Print 'N of P programs' (both in the JSON) instead. The five committed report.md lines are edited to what the generator now prints; the rest of the bot-generated reports are left to the evidence-refresh bot (#4703). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MQNoe4wPJgr7dbUvs3DG6D
squid-protocol
added
bug
squid-protocol
added this to the
Training Montage 🏋️ — Prepping to one-shot our 4th CICS to Java translation attempt milestone
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failure on main (and on #4793/#4794):
test_every_number_in_the_markdown_comes_from_the_json[aws-mainframe-modernization-carddemo]-> numbers not in report.json: ['43'].Root cause: not the options section. The summary line
- current levels: {programs - stale}; stale: {stale}printed a derived number (44 - 1 = 43) that report.json does not hold. It passed earlier only because stale was 0 (current == programs) or by coincidence. The #4792 refresh left 1 carddemo program stale.Fix (generator, not a weakened check): print
stale (*, last measured): N of P programs; the rest are current; N and P are both in the JSON. The every-number check is unchanged. The five committed report.md lines are edited to match what the generator now emits; I did not run--refresh(it rewrites ~20k lines of bot-generated data, and per #4703 the evidence-refresh bot owns that).test_evidence_report.pypasses with EVIDENCE_REPORT_ADVISORY=1;test_the_committed_reports_are_currentfails on main without it for unrelated bot lag. pr_gates --fast: 5/5.🤖 Generated with Claude Code
https://claude.ai/code/session_01MQNoe4wPJgr7dbUvs3DG6D