Skip to content

Fix failing tests #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allisonmoyer merged 2 commits into from
Jun 7, 2021
Merged

Fix failing tests #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfe7f66
Fix failing tests
allisonmoyer Jun 7, 2021
552a421
Update test variables from equivalentValet -> similarValet
allisonmoyer Jun 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Tests/ValetIntegrationTests/SecureEnclaveIntegrationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,10 @@ class SecureEnclaveIntegrationTests: XCTestCase
}

try valet.setString(passcode, forKey: key)
let equivalentValet = SecureEnclaveValet.valet(with: valet.identifier, accessControl: .devicePasscode)
XCTAssertNotEqual(valet, equivalentValet)
let similarValet = SecureEnclaveValet.valet(with: valet.identifier, accessControl: .devicePasscode)
XCTAssertNotEqual(valet, similarValet)
XCTAssertEqual(passcode, try valet.string(forKey: key, withPrompt: ""))
XCTAssertThrowsError(try equivalentValet.string(forKey: key, withPrompt: "")) { error in
XCTAssertThrowsError(try similarValet.string(forKey: key, withPrompt: "")) { error in
XCTAssertEqual(error as? KeychainError, .itemNotFound)
}
}
Expand Down
6 changes: 3 additions & 3 deletions Tests/ValetIntegrationTests/SinglePromptSecureEnclaveIntegrationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,10 @@ class SinglePromptSecureEnclaveIntegrationTests: XCTestCase
}

try valet().setString(passcode, forKey: key)
let equivalentValet = SecureEnclaveValet.valet(with: valet().identifier, accessControl: .devicePasscode)
XCTAssertNotEqual(valet(), equivalentValet)
let similarValet = SinglePromptSecureEnclaveValet.valet(with: valet().identifier, accessControl: .devicePasscode)
XCTAssertNotEqual(valet(), similarValet)
XCTAssertEqual(passcode, try valet().string(forKey: key, withPrompt: ""))
XCTAssertThrowsError(try equivalentValet.string(forKey: key, withPrompt: "")) { error in
XCTAssertThrowsError(try similarValet.string(forKey: key, withPrompt: "")) { error in
XCTAssertEqual(error as? KeychainError, .itemNotFound)
}
}
Expand Down