Fix failing tests#268
Conversation
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
=======================================
Coverage 86.60% 86.60%
=======================================
Files 16 16
Lines 1053 1053
=======================================
Hits 912 912
Misses 141 141 |
dfed
left a comment
dfed
left a comment
There was a problem hiding this comment.
LGTM, but how was this test failing before? Def seems like a copy/paste issue but since we were testing that these were different I'd expect the tests to have been succeeding.
|
|
||
| try valet().setString(passcode, forKey: key) | ||
| let equivalentValet = SecureEnclaveValet.valet(with: valet().identifier, accessControl: .devicePasscode) | ||
| let equivalentValet = SinglePromptSecureEnclaveValet.valet(with: valet().identifier, accessControl: .devicePasscode) |
There was a problem hiding this comment.
This makes sense. Though maybe let's rename equivalentValet to similarValet since they aren't actually equivalent?
I'm not sure. There's more that are failing locally for me as well (like |
|
On target are the tests failing? If it's macOS there's likely a code-signing issue. Check out these instructions. |
4 participants
No description provided.