Skip to content

Add section in docs for token rotation - #413

Merged
seratch merged 2 commits into
slackapi:mainfrom
misscoded:token-rotation-docs
Jul 21, 2021
Merged

seratch merged 2 commits into
slackapi:mainfrom
misscoded:token-rotation-docs

Conversation

@misscoded

Copy link
Copy Markdown
Contributor

Add section to documentation that outlines token rotation and links out to corresponding release notes, spec and API documentation.

Screen Shot 2021-07-20 at 7 15 12 PM

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@misscoded misscoded added the docs Improvements or additions to documentation label Jul 21, 2021
@misscoded
misscoded requested a review from seratch July 21, 2021 02:57
@seratch seratch modified the milestones: 1.8.0, 1.7.0 Jul 21, 2021

@seratch seratch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me 👍 I just reran the failed CI build due to GitHub runtime issue. Once the builds pass, we can merge this PR.

@seratch

seratch commented Jul 21, 2021

Copy link
Copy Markdown
Contributor

#416 will fix the build error

@codecov

codecov Bot commented Jul 21, 2021

Copy link
Copy Markdown

Codecov Report

Merging #413 (08c8cc0) into main (f0d2699) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #413   +/-   ##
=======================================
  Coverage   91.36%   91.36%           
=======================================
  Files         167      167           
  Lines        5491     5491           
=======================================
  Hits         5017     5017           
  Misses        474      474           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0d2699...08c8cc0. Read the comment docs.

@seratch
seratch merged commit 35baf08 into slackapi:main Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants