Repository navigation
Fix #330 Potentially request.body can be None when using a custom adapter - #331
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #331 +/- ##
==========================================
+ Coverage 91.48% 91.54% +0.05%
==========================================
Files 167 167
Lines 5369 5367 -2
==========================================
+ Hits 4912 4913 +1
+ Misses 457 454 -3
Continue to review full report at Codecov.
|
seratch
commented
May 9, 2021
| return "`body` must be a raw string data when running in the HTTP server mode" | ||
|
|
||
|
|
||
| def error_message_unknown_request_body_type() -> str: |
Contributor
Author
There was a problem hiding this comment.
Removed this error message template as it's in internals source file and I'm sure no code outside this project uses it.
mwbrooks
approved these changes
May 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves #330 by updating the request parsers.
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.