Potentially request.body can be None when using a custom adapter

I think you should swap the order of this line, with aws_lambda body is None so the code will raise the exception inside the if condition. L49 not make any sense in this order because if body is None the code will always raise exception inside the if condition

bolt-python/slack_bolt/request/request.py

Lines 47 to 49 in 31436f7

    
           if not isinstance(body, str): 
        
               raise BoltError(error_message_raw_body_required_in_http_mode()) 
        
           self.raw_body = body if body is not None else ""

@matteobaldelli

Hi @matteobaldelli, thanks for taking the time to report this issue!

As long as you use the adapter in this project, the body cannot be None. However, if a developer implements their own adapter, the body is possibly None in some cases.

I will update the code (perhaps, rather than swapping the lines, I will update the L47 to check if it's not None).

Fix #330 Potentially request.body can be None when using a custom ada…

Navigation Menu

Repository navigation

Potentially request.body can be None when using a custom adapter #330

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if not isinstance(body, str):
	raise BoltError(error_message_raw_body_required_in_http_mode())
	self.raw_body = body if body is not None else ""

Potentially request.body can be None when using a custom adapter #330

Description

Activity

seratch commented on May 8, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions