Skip to content

Fix #210 by correcting a type hint in async OAuth classes #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seratch merged 1 commit into from
Jan 18, 2021
Merged

Fix #210 by correcting a type hint in async OAuth classes #213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions slack_bolt/oauth/async_oauth_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
AsyncAuthorize,
)
from slack_bolt.error import BoltError
from slack_bolt.oauth.async_callback_options import AsyncCallbackOptions
from slack_bolt.oauth.async_internals import get_or_create_default_installation_store
from slack_bolt.oauth.callback_options import CallbackOptions


class AsyncOAuthSettings:
Expand All @@ -34,7 +34,7 @@ class AsyncOAuthSettings:
install_path: str
install_page_rendering_enabled: bool
redirect_uri_path: str
callback_options: Optional[CallbackOptions] = None
callback_options: Optional[AsyncCallbackOptions] = None
success_url: Optional[str]
failure_url: Optional[str]
authorization_url: str # default: https://slack.com/oauth/v2/authorize
Expand Down Expand Up @@ -66,7 +66,7 @@ def __init__(
install_path: str = "/slack/install",
install_page_rendering_enabled: bool = True,
redirect_uri_path: str = "/slack/oauth_redirect",
callback_options: Optional[CallbackOptions] = None,
callback_options: Optional[AsyncCallbackOptions] = None,
success_url: Optional[str] = None,
failure_url: Optional[str] = None,
authorization_url: Optional[str] = None,
Expand Down