Skip to content

Fix #210 by correcting a type hint in async OAuth classes - #213

Merged
seratch merged 1 commit into
slackapi:mainfrom
seratch:issue-210-type-hints
Jan 18, 2021
Merged

seratch merged 1 commit into
slackapi:mainfrom
seratch:issue-210-type-hints

Conversation

@seratch

@seratch seratch commented Jan 18, 2021

Copy link
Copy Markdown
Contributor

This pull request fixes #210 - this issue does not affect anything runtime. It's just an error for type hint users.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added bug Something isn't working area:async labels Jan 18, 2021
@seratch seratch added this to the 1.2.2 milestone Jan 18, 2021
@seratch seratch self-assigned this Jan 18, 2021
@codecov

codecov Bot commented Jan 18, 2021

Copy link
Copy Markdown

Codecov Report

Merging #213 (23dd3aa) into main (a11f6d1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #213   +/-   ##
=======================================
  Coverage   91.61%   91.61%           
=======================================
  Files         159      159           
  Lines        4746     4746           
=======================================
  Hits         4348     4348           
  Misses        398      398           
Impacted Files Coverage Δ
slack_bolt/oauth/async_oauth_settings.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a11f6d1...23dd3aa. Read the comment docs.

@seratch
seratch merged commit 90bfe6a into slackapi:main Jan 18, 2021
@seratch
seratch deleted the issue-210-type-hints branch January 18, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:async bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AsyncOAuthSettings uses CallbackOptions instead of AsyncCallbackOptions

2 participants