Skip to content

Fix #208 by updating AsyncOAuthFlow - #212

Merged
seratch merged 1 commit into
slackapi:mainfrom
seratch:issue-208-fix-async-oauth-flow
Jan 18, 2021
Merged

seratch merged 1 commit into
slackapi:mainfrom
seratch:issue-208-fix-async-oauth-flow

Conversation

@seratch

@seratch seratch commented Jan 18, 2021 •

Copy link
Copy Markdown
Contributor

This pull request fixes #208 by updating AsyncOAuthFlow to new attributes introduced by #148. This bug has been affecting only AsyncApp (asyncio compatible version).

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added bug Something isn't working area:async labels Jan 18, 2021
@seratch seratch added this to the 1.2.2 milestone Jan 18, 2021
@seratch seratch self-assigned this Jan 18, 2021
@codecov

codecov Bot commented Jan 18, 2021

Copy link
Copy Markdown

Codecov Report

Merging #212 (0d242ee) into main (a11f6d1) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   91.61%   91.60%   -0.02%     
==========================================
  Files         159      159              
  Lines        4746     4750       +4     
==========================================
+ Hits         4348     4351       +3     
- Misses        398      399       +1     
Impacted Files Coverage Δ
slack_bolt/oauth/oauth_flow.py 90.43% <ø> (ø)
slack_bolt/oauth/async_oauth_flow.py 90.75% <75.00%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a11f6d1...0d242ee. Read the comment docs.

@seratch
seratch merged commit 16d2908 into slackapi:main Jan 18, 2021
@seratch
seratch deleted the issue-208-fix-async-oauth-flow branch January 18, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:async bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AsyncOAuthFlow run_installation missing team_name and enterprise_name fields in returned Installation

2 participants