Skip to content

AsyncOAuthFlow run_installation missing team_name and enterprise_name fields in returned Installation #208

Closed
#212
Closed
AsyncOAuthFlow run_installation missing team_name and enterprise_name fields in returned Installation#208
#212
Assignees
seratch
Labels
area:asyncbugSomething isn't working
Milestone
1.2.2

Description

@jwelch92
jwelch92
opened on Jan 15, 2021

Reproducible in:

pip freeze | grep slack
python --version
sw_vers && uname -v # or `ver`

The slack_bolt version

slack-bolt==1.1.4
reproduced on fresh checkout of main

Python runtime version

Not relevant for this bug but Python 3.6.9.

OS info

N/A

Expected result:

See non-async OAuthFlow.run_installation

Actual result:

See AsyncOAuthFlow.run_installation

The fields team_name and enterprise_name are not pulled out of the request for use in the Installation.

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

Activity

  1. seratch
    added this to the 1.2.2 milestone on Jan 15, 2021
  2. seratch
    added
    area:async
    bugSomething isn't working
    on Jan 15, 2021
  3. seratch
    self-assigned this
    on Jan 15, 2021

  4. seratch commented on Jan 15, 2021

    @seratch
    seratch
    on Jan 15, 2021
    Contributor

    @jwelch92 Thanks a lot for taking the time to report this!

    Yes, you are right. This is a bug in AsyncOAuthFlow. We will be fixing this issue early next week. If it is urgent for you, a workaround is to have your own AsyncOAuthFlow subclass and override the method.

  5. jwelch92 commented on Jan 15, 2021

    @jwelch92
    jwelch92
    on Jan 15, 2021
    Author

    @jwelch92 Thanks a lot for taking the time to report this!

    Yes, you are right. This is a bug in AsyncOAuthFlow. We will be fixing this issue early next week. If it is urgent for you, a workaround is to have your own AsyncOAuthFlow subclass and override the method.

    Thanks @seratch! I ended up working around it for now but I will update as soon as this is fixed and released. I uncovered another unrelated issue while working on this so I'll file a separate ticket.

  6. seratch
    closed this as completedin #212on Jan 18, 2021
  7. seratch
    added a commit that references this issue on Jan 18, 2021

    Fix #208 by updating AsyncOAuthFlow

    16d2908
  8. nickovs
    added a commit that references this issue on Jan 20, 2021

    Fix slackapi#208 by updating AsyncOAuthFlow

    e09a879
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:asyncbugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions