Repository navigation
Socket Mode support - #176
Merged
Merged
Conversation
seratch
force-pushed
the
feat-socket-mode
branch
from
December 14, 2020 00:39
b609410 to
bef775c
Compare
Codecov Report
@@ Coverage Diff @@
## main #176 +/- ##
==========================================
- Coverage 92.12% 91.61% -0.52%
==========================================
Files 149 159 +10
Lines 4508 4744 +236
==========================================
+ Hits 4153 4346 +193
- Misses 355 398 +43
Continue to review full report at Codecov.
|
Contributor
Author
|
I've already verified the implementation has been stably working with Socket Mode connections for weeks but this PR still lacks unit tests for the new Socket Mode adapter. I will add some tests in this PR by the end of this week. |
seratch
force-pushed
the
feat-socket-mode
branch
from
January 9, 2021 17:16
ee9ec2d to
b76c8eb
Compare
seratch
force-pushed
the
feat-socket-mode
branch
from
January 9, 2021 17:35
e953a8c to
00959d2
Compare
added inital socket mode document
stevengill
approved these changes
Jan 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is for Socket Mode support #159. The details of Socket Mode is not yet publicly shared. As it's still in beta, the implementation on this SDK side can be changed until the GA release (v1.2.0) I used to use #160 for Socket Mode development, but we will continue with
feat-socket-modebranch in this repository from now on.Remaining TODOs are:
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.