Skip to content

Add Socket Mode support #159 - #160

Closed
seratch wants to merge 4 commits into
slackapi:mainfrom
seratch:issue-159-socket-mode
Closed

seratch wants to merge 4 commits into
slackapi:mainfrom
seratch:issue-159-socket-mode

Conversation

@seratch

@seratch seratch commented Nov 25, 2020 •

Copy link
Copy Markdown
Contributor

This pull request is still work in progress. The details can be changed until the GA release (v1.2.0)

#159

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added this to the 1.2.0 milestone Nov 25, 2020
@seratch
seratch requested a review from stevengill November 25, 2020 03:41
@seratch seratch self-assigned this Nov 25, 2020
@seratch
seratch marked this pull request as draft November 25, 2020 03:43
@codecov-io

codecov-io commented Nov 25, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #160 (3833bf3) into main (1d01c67) will decrease coverage by 4.20%.
The diff coverage is 0.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
- Coverage   91.72%   87.51%   -4.21%     
==========================================
  Files         149      159      +10     
  Lines        4434     4630     +196     
==========================================
- Hits         4067     4052      -15     
- Misses        367      578     +211     
Impacted Files Coverage Δ
slack_bolt/adapter/socket_mode/__init__.py 0.00% <0.00%> (ø)
slack_bolt/adapter/socket_mode/aiohttp/__init__.py 0.00% <0.00%> (ø)
...ack_bolt/adapter/socket_mode/async_base_handler.py 0.00% <0.00%> (ø)
slack_bolt/adapter/socket_mode/async_handler.py 0.00% <0.00%> (ø)
slack_bolt/adapter/socket_mode/async_internals.py 0.00% <0.00%> (ø)
slack_bolt/adapter/socket_mode/base_handler.py 0.00% <0.00%> (ø)
slack_bolt/adapter/socket_mode/builtin/__init__.py 0.00% <0.00%> (ø)
slack_bolt/adapter/socket_mode/internals.py 0.00% <0.00%> (ø)
...t/adapter/socket_mode/websocket_client/__init__.py 0.00% <0.00%> (ø)
...ck_bolt/adapter/socket_mode/websockets/__init__.py 0.00% <0.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d01c67...b609410. Read the comment docs.

@seratch seratch mentioned this pull request Dec 8, 2020
8 of 11 tasks
@seratch seratch closed this Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants