Skip to content

Swift 6.1#6

Open
dfabulich wants to merge 1 commit into
skiptools:mainfrom
dfabulich:swift-6.1
Open

Swift 6.1#6
dfabulich wants to merge 1 commit into
skiptools:mainfrom
dfabulich:swift-6.1

Conversation

@dfabulich

Copy link
Copy Markdown
Member

We're using @preconcurrency import SkipFirebaseMessaging (Messaging should be Sendable but isn't) and @preconcurrency import SkipFirebaseFirestore (Firestore and CollectionReference should be Sendable but aren't).

We're also making our NotificationDelegate Sendable, so its methods can use @MainActor, and we're using @preconcurrency UNUserNotificationCenterDelegate so Swift doesn't complain that our @MainActor implementations don't fulfill the protocol.

Skip Pull Request Checklist:

  • REQUIRED: I have signed the Contributor Agreement
  • REQUIRED: I have tested my change locally with swift test
  • OPTIONAL: I have tested my change on an iOS simulator or device
  • OPTIONAL: I have tested my change on an Android emulator or device

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

We're using `@preconcurrency import SkipFirebaseMessaging` (`Messaging` should be `Sendable` but isn't) and `@preconcurrency import SkipFirebaseFirestore` (`Firestore` and `CollectionReference` should be `Sendable` but aren't).

We're also making our `NotificationDelegate` `Sendable`, so its methods can use `@MainActor`, and we're using `@preconcurrency UNUserNotificationCenterDelegate` so Swift doesn't complain that our `@MainActor` implementations don't fulfill the protocol.
@cla-bot cla-bot Bot added the cla-signed label Jun 5, 2026
@dfabulich dfabulich mentioned this pull request Jun 5, 2026
5 tasks
@dfabulich

Copy link
Copy Markdown
Member Author

I filed skiptools/skip-firebase#87 so we don't have to add @preconcurrency to our imports. But @preconcurrency works, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant