Swift 6.1#87
Merged
Merged
Conversation
Otherwise, users will have to do this to get their code to compile on Swift 6.1
Without `@MainActor`, the app will crash when receiving notifications while the app is in the background. And, in order to get Swift 6.1+ to _allow_ you to use `@MainActor`, we have to use `@preconcurrency UNUserNotificationCenterDelegate`. (In Swift 6.2+, we can use isolated conformances, but Swift Lite doesn't support 6.2 yet, so I'm using `@preconcurrency` instead.)
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In skiptools/skipapp-fireside#6 I fixed it by adding
@preconcurrencyto myimport SkipFirebaseMessagingandimport SkipFirebaseFirestorecalls. In this PR, I'm adding@retroactive @unchecked Sendableconformance toMessaging,Firestore, andCollectionReference, so users don't have to do it themselves.I'm also documenting how to use
@MainActoronNotificationDelegate(it can crash the app if you don't add it).Skip Pull Request Checklist:
swift testTested in
skipapp-fireside.