Skip to content

fix(helm): move rotationPolicy under privateKey for cert-manager compatibility #3046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 3 commits into from
Jan 28, 2026
Merged

fix(helm): move rotationPolicy under privateKey for cert-manager compatibility #3046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34af8e4
fix(helm): move rotationPolicy under privateKey for cert-manager comp…
waleedlatif1 Jan 28, 2026
afeadea
docs(helm): add reclaimPolicy Retain guidance for production database…
waleedlatif1 Jan 28, 2026
c644588
fix(helm): prevent empty branding ConfigMap creation
waleedlatif1 Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions helm/sim/examples/values-azure.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@
# Global configuration
global:
imageRegistry: "ghcr.io"
# Use "managed-csi-premium" for Premium SSD (requires Premium storage-capable VMs like Standard_DS*)
# Use "managed-csi" for Standard SSD (works with all VM types)
# Use "managed-csi-premium" for Premium SSD, "managed-csi" for Standard SSD
# IMPORTANT: For production, use a StorageClass with reclaimPolicy: Retain
# to protect database volumes from accidental deletion.
storageClass: "managed-csi"

# Main application
Expand Down
1 change: 1 addition & 0 deletions helm/sim/examples/values-production.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
# Global configuration
global:
imageRegistry: "ghcr.io"
# For production, use a StorageClass with reclaimPolicy: Retain
storageClass: "managed-csi-premium"

# Main application
Expand Down
6 changes: 3 additions & 3 deletions helm/sim/templates/certificate-postgresql.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ spec:
duration: {{ .Values.postgresql.tls.duration | default "87600h" }} # Default: 10 years
renewBefore: {{ .Values.postgresql.tls.renewBefore | default "2160h" }} # Default: 90 days before expiry
isCA: false
{{- if .Values.postgresql.tls.rotationPolicy }}
rotationPolicy: {{ .Values.postgresql.tls.rotationPolicy }}
{{- end }}
privateKey:
algorithm: {{ .Values.postgresql.tls.privateKey.algorithm | default "RSA" }}
size: {{ .Values.postgresql.tls.privateKey.size | default 4096 }}
{{- if .Values.postgresql.tls.rotationPolicy }}
rotationPolicy: {{ .Values.postgresql.tls.rotationPolicy }}
{{- end }}
usages:
- server auth
- client auth
Expand Down
2 changes: 1 addition & 1 deletion helm/sim/templates/configmap-branding.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if .Values.branding.enabled }}
{{- if and .Values.branding.enabled (or .Values.branding.files .Values.branding.binaryFiles) }}
---
# Branding ConfigMap
# Mounts custom branding assets (logos, CSS, etc.) into the application
Expand Down
10 changes: 6 additions & 4 deletions helm/sim/templates/deployment-app.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,10 @@ spec:
{{- end }}
{{- include "sim.resources" .Values.app | nindent 10 }}
{{- include "sim.securityContext" .Values.app | nindent 10 }}
{{- if or .Values.branding.enabled .Values.extraVolumeMounts .Values.app.extraVolumeMounts }}
{{- $hasBranding := and .Values.branding.enabled (or .Values.branding.files .Values.branding.binaryFiles) }}
{{- if or $hasBranding .Values.extraVolumeMounts .Values.app.extraVolumeMounts }}
volumeMounts:
{{- if .Values.branding.enabled }}
{{- if $hasBranding }}
- name: branding
mountPath: {{ .Values.branding.mountPath | default "/app/public/branding" }}
readOnly: true
Expand All @@ -124,9 +125,10 @@ spec:
{{- toYaml . | nindent 12 }}
{{- end }}
{{- end }}
{{- if or .Values.branding.enabled .Values.extraVolumes .Values.app.extraVolumes }}
{{- $hasBranding := and .Values.branding.enabled (or .Values.branding.files .Values.branding.binaryFiles) }}
{{- if or $hasBranding .Values.extraVolumes .Values.app.extraVolumes }}
volumes:
{{- if .Values.branding.enabled }}
{{- if $hasBranding }}
- name: branding
configMap:
name: {{ include "sim.fullname" . }}-branding
Expand Down