Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

@waleedlatif1 waleedlatif1 commented Jan 27, 2026

icecrasher321 and others added 11 commits January 26, 2026 10:16
* fix(codegen): function prologue resolution edge cases

* remove hacky fallback

* case insensitive lookup

* fix python nan and inf resolution

* remove template literal check

* fix tests

* consolidate literal gen
…ce (#3007)

* fix(docs): separate local and blob asset resolution for quick-reference

ActionImage now uses local paths directly for PNGs while ActionVideo
uses blob storage with proper path normalization (strips static/ prefix).

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* refactor(docs): simplify asset resolution by using correct paths directly

Remove path normalization logic from action-media component. Instead,
use the appropriate paths in MDX:
- PNGs: /static/quick-reference/... (local)
- MP4s: quick-reference/... (blob via getAssetUrl)

---------

Co-authored-by: Claude Opus 4.5 <[email protected]>
…igurations (#3013)

* improvement(preview): consolidate block rendering and fix handle configurations

* refactor(preview): extract SubflowContainerProps interface
…d minor styling inconsistencies between themes (#3014)

* improvement(docs): updated logo, added lightbox to action media, fixed minor styling inconsistencies between themes

* updated og image

* ack comments
)

* fix input format

* fix tests

* address bugbot comment
* fix(kb): workspace id required for creation

* fix tests
* fix(max-tokens): anthropic models streaming vs non-streaming

* default max inc

* update the docs
…#3016)

* feat(note-block): expand media embed support with tuned aspect ratios

* fix(note-block): add artist parameter to Bandcamp embed URLs

Include the artist subdomain in Bandcamp track and album embed URLs
to ensure proper embed resolution.

* fix(note-block): add required src attribute to track elements

HTML spec requires track elements to have a src attribute.

* fix(note-block): address embed URL matching issues

- Fix YouTube regex to handle v= anywhere in query params
- Fix Twitch channel match to exclude /clip/ URLs
- Remove Mux support (HLS not supported in most browsers)
- Remove Bandcamp support (requires numeric IDs, not slugs)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

---------

Co-authored-by: Claude Opus 4.5 <[email protected]>
@vercel
Copy link

vercel bot commented Jan 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
docs Ready Ready Preview, Comment Jan 27, 2026 5:43am

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 27, 2026

Greptile Overview

Greptile Summary

This PR consolidates 11 separate feature/fix PRs into a single release (v0.5.73), covering CI automation, Helm deployment, knowledge base fixes, UI improvements, and provider enhancements.

Key Changes:

  • LLM Provider Fix: Resolved max-tokens discrepancy between streaming (64K) and non-streaming (8K default) requests to prevent timeouts in Anthropic and Bedrock providers
  • Knowledge Base: Made workspaceId required for KB creation, eliminating optional workspace handling
  • Code Generation: New formatLiteralForCode utility properly handles Python vs JavaScript literal formatting (None/null, True/false, float('nan')/NaN) fixing function block code generation edge cases
  • Input Format Resolution: Fixed blocks with inputFormat fields (triggers, starter, HITL) to properly expose custom fields as outputs
  • Copilot UX: Improved zoom-to-changed-blocks behavior by waiting for node dimensions before focusing
  • Preview Rendering: Consolidated subflow rendering into block component, added lightweight mode for performance
  • Media Embeds: Expanded note block support to 15+ platforms (Vimeo, Spotify, TikTok, etc.) with tuned aspect ratios
  • Docs: Fixed asset resolution for CDN/local environments, added lightbox for media
  • CI/CD: Auto-creates GitHub releases after successful builds
  • Helm: Added branding ConfigMap for custom logo/CSS assets

Confidence Score: 5/5

  • This PR is safe to merge with no critical issues found
  • All changes are well-structured bug fixes and incremental improvements. The max-tokens fix properly handles streaming vs non-streaming, the code formatting utility is thoroughly documented, the knowledge base change enforces required fields, and the UI improvements are isolated. No breaking changes or security concerns identified.
  • No files require special attention

Important Files Changed

Filename Overview
apps/sim/providers/anthropic/index.ts Fixed max-tokens handling for streaming vs non-streaming requests using new utility function
apps/sim/providers/bedrock/index.ts Applied same max-tokens fix for streaming vs non-streaming consistency
apps/sim/providers/models.ts Added maxOutputTokens capability with separate values for streaming (max: 64000) and non-streaming (default: 8192) to prevent timeouts
apps/sim/lib/knowledge/service.ts Made workspaceId required for knowledge base creation, removed conditional permission check
apps/sim/executor/utils/code-formatting.ts New utility to format JavaScript/TypeScript values as Python or JavaScript literals, handling edge cases like NaN, Infinity, booleans
apps/sim/executor/variables/resolvers/block.ts Refactored to use formatLiteralForCode utility for proper Python/JavaScript code generation in function blocks
apps/sim/executor/utils/block-data.ts Fixed inputFormat field resolution for blocks with custom input fields (triggers, starter, human_in_the_loop)
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsx Fixed zoom-to-changed-blocks timing issue by waiting for node dimensions before focusing on diff changes
apps/sim/app/workspace/[workspaceId]/w/components/preview/components/block.tsx Consolidated block rendering with subflow container support (loop/parallel), added lightweight mode for performance
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/note-block/note-block.tsx Massively expanded media embed support: added Vimeo, Dailymotion, Twitch, TikTok, Spotify, Apple Music, SoundCloud, Loom, Instagram, Facebook with custom aspect ratios
apps/docs/content/docs/en/quick-reference/index.mdx Fixed asset paths to use relative paths instead of /static/ prefix for proper CDN/local resolution
.github/workflows/ci.yml Added auto-release job to create GitHub releases after successful builds, added read permissions
helm/sim/templates/configmap-branding.yaml New Helm template for custom branding assets (logos, CSS) via ConfigMap

Sequence Diagram

sequenceDiagram
    participant User
    participant CI as GitHub CI
    participant App as Sim App
    participant Provider as LLM Provider
    participant Executor as Code Executor
    participant KB as Knowledge Base
    participant Helm as Helm Chart

    Note over User,Helm: v0.5.73 Release Flow

    User->>CI: Push version commit to main
    CI->>CI: Run tests and build
    CI->>CI: Create GHCR manifests
    CI->>CI: Detect version from commit
    CI->>CI: Create GitHub release

    Note over User,App: Knowledge Base Creation

    User->>App: Create knowledge base
    App->>KB: createKnowledgeBase(data)
    KB->>KB: Validate workspaceId (required)
    KB->>KB: Check user permissions
    KB->>KB: Create KB with workspaceId
    KB-->>App: Return KB details

    Note over User,Provider: LLM Request Flow

    User->>App: Execute workflow with LLM block
    App->>Provider: Generate completion request
    Provider->>Provider: getMaxOutputTokensForModel(model, streaming)
    alt Streaming Request
        Provider->>Provider: Use max: 64000 tokens
    else Non-Streaming Request
        Provider->>Provider: Use default: 8192 tokens (prevent timeout)
    end
    Provider->>Provider: Execute LLM request
    Provider-->>App: Return completion

    Note over User,Executor: Function Block Code Generation

    User->>App: Reference block output in function
    App->>Executor: Resolve variable reference
    Executor->>Executor: formatLiteralForCode(value, language)
    alt Python Function
        Executor->>Executor: Convert to Python literals (None, True, False, float('nan'))
    else JavaScript Function
        Executor->>Executor: Convert to JS literals (null, true, false, NaN)
    end
    Executor-->>App: Return formatted code

    Note over User,App: Copilot Diff Zoom

    User->>App: Apply copilot diff
    App->>App: Detect changed blocks
    App->>App: Wait for node dimensions
    App->>App: fitViewToBounds(changedNodes)
    App-->>User: Zoom to changed blocks

    Note over User,Helm: Helm Branding Deployment

    User->>Helm: Deploy with branding.enabled=true
    Helm->>Helm: Create branding ConfigMap
    Helm->>Helm: Mount ConfigMap to deployment
    Helm-->>User: Deploy with custom assets
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

* improvement(switch): dark styling

* improvement(settings): change deployed MCPs to MCPs servers

* improvement(preview): added error paths, loop logic

* improvement(preview): nested workflows preview

* feat(preview): lightweight param

* improvement(preview): staging changes integrated
@waleedlatif1 waleedlatif1 changed the title v0.5.73: ci, helm updates, kb, ui fixes v0.5.73: ci, helm updates, kb, ui fixes. note block enhancements Jan 27, 2026
* feat(code): undo-redo state

* address greptile

* address bugbot comments

* fix debounce flush

* inc debounce time

* fix wand case

* address comments
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@waleedlatif1 waleedlatif1 merged commit ab4e9dc into main Jan 27, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants