-
Notifications
You must be signed in to change notification settings - Fork 3.3k
improvement(preview): error paths, loops, workflow #3010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile OverviewGreptile SummaryRefactored workflow preview architecture to support nested workflow navigation, improved error path visualization, and updated UI terminology. Key changes:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Preview
participant PreviewWorkflow
participant PreviewEditor
participant ReactFlow
User->>Preview: View workflow execution
Preview->>Preview: buildBlockExecutions(traceSpans)
Preview->>Preview: Initialize pinnedBlockId (leftmost block)
Preview->>PreviewWorkflow: Render workflow canvas
PreviewWorkflow->>ReactFlow: Render nodes and edges
ReactFlow-->>User: Display workflow visualization
Preview->>PreviewEditor: Render editor sidebar (pinned block)
PreviewEditor-->>User: Display block input/output
alt User clicks on block
User->>PreviewWorkflow: Click block
PreviewWorkflow->>Preview: onNodeClick(blockId)
Preview->>Preview: setPinnedBlockId(blockId)
Preview->>PreviewEditor: Update editor with new block
PreviewEditor-->>User: Show selected block details
end
alt User drills into nested workflow (loop/parallel)
User->>PreviewEditor: Click "View Workflow" on loop/parallel block
PreviewEditor->>Preview: onDrillDown(blockId, childWorkflowState)
Preview->>Preview: extractChildTraceSpans(blockExecution)
Preview->>Preview: buildBlockExecutions(childTraceSpans)
Preview->>Preview: Push to workflowStack
Preview->>Preview: Set pinned block to leftmost in child
Preview->>PreviewWorkflow: Render child workflow
PreviewWorkflow->>ReactFlow: Render child nodes/edges
Preview->>PreviewEditor: Show child block details
Preview-->>User: Display "Back" button
end
alt User goes back from nested workflow
User->>Preview: Click "Back" button
Preview->>Preview: Pop from workflowStack
Preview->>Preview: Clear pinnedBlockId
Preview->>PreviewWorkflow: Render parent workflow
Preview->>PreviewEditor: Hide editor
end
alt Error path execution
PreviewWorkflow->>PreviewWorkflow: Check edgeRunStatus
alt Error edge was taken
PreviewWorkflow->>ReactFlow: Color edge green (success)
else Error edge not taken
PreviewWorkflow->>ReactFlow: Color edge red (error)
end
end
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No files reviewed, no comments
|
@greptile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No files reviewed, no comments
ff53e0e to
7caa1f5
Compare
|
@greptile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No files reviewed, no comments
Summary
Type of Change
Testing
Solo.
Checklist