Rename max IL transactions bytes constant per spec change - #9741
Conversation
…LUSION_LIST following the spec change
|
Some required checks have failed. Could you please take a look @conache? 🙏 |
eserilev
left a comment
There was a problem hiding this comment.
this is fine but i think we should extend the scope of this PR a little bit
Lighthouse never reads this value from a config file. The number 8192 is hardcoded. If a devnet config sets a different value, Lighthouse ignores it and uses 8192 anyway, with no warning.
The fix would be to add the field to the Config struct, and remove the key from the UPSTREAM_KEYS_NOT_IN_LIGHTHOUSE list. Then config files control the value, like every other networking parameter. We should double check that other IL config values are also in the Config struct
Thank you for the context! This makes sense. I added the suggested change for I also double-checked the other IL config values and found out that the following had the same problem (and added fixes for them):
|
Merge Queue Status
This pull request spent 28 minutes 51 seconds in the queue, including 26 minutes 48 seconds running CI. Required conditions to merge
|
Proposed Changes
Rename
MAX_BYTES_PER_INCLUSION_LISTtoMAX_TRANSACTIONS_BYTES_PER_INCLUSION_LISTper consensus-specs#5508 PR.Add the missing IL config values to the
Configstruct, so config file values can modify them instead of Lighthouse silently using its hardcoded defaults:MAX_TRANSACTIONS_BYTES_PER_INCLUSION_LISTMAX_REQUEST_INCLUSION_LISTMIN_SLOTS_FOR_INCLUSION_LISTS_REQUESTS