Rename the max IL transaction size constant name - #5508
Merged
jihoonsong merged 2 commits intoAug 3, 2026
Merged
Conversation
jtraglia
reviewed
Aug 1, 2026
jihoonsong
force-pushed
the
inclusion-list-max-size-const
branch
from
August 3, 2026 10:30
5052020 to
0ae32aa
Compare
jtraglia
approved these changes
Aug 3, 2026
jihoonsong
enabled auto-merge (squash)
August 3, 2026 11:50
4 tasks
mergify Bot
pushed a commit
to sigp/lighthouse
that referenced
this pull request
Aug 11, 2026
## Proposed Changes - Rename `MAX_BYTES_PER_INCLUSION_LIST` to `MAX_TRANSACTIONS_BYTES_PER_INCLUSION_LIST` per [consensus-specs#5508 PR](ethereum/consensus-specs#5508). - Add the missing IL config values to the `Config` struct, so config file values can modify them instead of Lighthouse silently using its hardcoded defaults: - `MAX_TRANSACTIONS_BYTES_PER_INCLUSION_LIST` - `MAX_REQUEST_INCLUSION_LIST` - `MIN_SLOTS_FOR_INCLUSION_LISTS_REQUESTS`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been asked several times how inclusion list size is measured. This PR renames
MAX_BYTES_PER_INCLUSION_LISTtoMAX_TRANSACTION_BYTES_PER_INCLUSION_LISTMAX_TRANSACTIONS_BYTES_PER_INCLUSION_LISTto remove the ambiguity.