Persist data columns to store#6255
Merged
Merged
Conversation
jimmygchen
added
ready-for-review
realbigsean
approved these changes
Aug 13, 2024
realbigsean
left a comment
realbigsean
left a comment
Member
There was a problem hiding this comment.
looks pretty straightforward
dapplion
force-pushed
the
peerdas-network-rpc-handler
branch
from
25c1647 to
34f796d
Compare
jimmygchen
changed the base branch from
peerdas-network-rpc-handler
to
unstable
jimmygchen
force-pushed
the
gossip-handling-store-wire-up
branch
from
96acf78 to
bd95311
Compare
Member
Author
|
I've rebased this back to |
jimmygchen
force-pushed
the
gossip-handling-store-wire-up
branch
from
bd95311 to
2b3fb66
Compare
Member
Author
|
Thanks for the quick review @realbigsean ! 🙏 |
jimmygchen
added
ready-for-merge
Member
|
@mergify queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 18df701 |
AgeManning
pushed a commit
to AgeManning/lighthouse
that referenced
this pull request
Sep 3, 2024
* Persist data columns (from das PR sigp#5196)
chong-he
pushed a commit
to chong-he/lighthouse
that referenced
this pull request
Nov 26, 2024
* Persist data columns (from das PR sigp#5196)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
This small PR contains some remaining changes from #5196 to persist data columns for blocks that have been made available
Built on top of #6237.