Skip to content

Implement PeerDAS RPC handlers#6237

Merged
mergify[bot] merged 4 commits into
unstablefrom
peerdas-network-rpc-handler
Aug 15, 2024
Merged

Implement PeerDAS RPC handlers#6237
mergify[bot] merged 4 commits into
unstablefrom
peerdas-network-rpc-handler

Conversation

@dapplion

@dapplion dapplion commented Aug 7, 2024 •
edited by jimmygchen
Loading

Copy link
Copy Markdown
Collaborator

Issue Addressed

Continue porting network changes of das branch. Extends #6238

Part of

all branches are on the sipg/lighthouse repo to start another PR conga :)

Proposed Changes

  • Implement serving RPC handlers for data_columns_by_root and data_columns_by_range.
  • This PR excludes the feature to reprocess early sampling requests.

Upstream PRs:

@dapplion dapplion added do-not-merge das Data Availability Sampling das-unstable-merge labels Aug 7, 2024
@jimmygchen jimmygchen mentioned this pull request Aug 7, 2024
Closed
@jimmygchen jimmygchen changed the base branch from peerdas-network-boilerplate to unstable August 13, 2024 05:30
@jimmygchen jimmygchen force-pushed the peerdas-network-rpc-handler branch from dc6a186 to 42de037 Compare August 13, 2024 05:42
@jimmygchen jimmygchen changed the base branch from unstable to peerdas-network-processor August 13, 2024 05:42
@jimmygchen

jimmygchen commented Aug 13, 2024

Copy link
Copy Markdown
Member

Oops I thought this was the first PR in the conga line and incorrectly set the base branch to unstable. I've reverted my merge commit and it's now back to what it was before.

@jimmygchen

jimmygchen commented Aug 13, 2024

Copy link
Copy Markdown
Member

I've merged latest base branch into this branch so i can extend the conga line.

@jimmygchen jimmygchen mentioned this pull request Aug 13, 2024
Merged
realbigsean
realbigsean reviewed Aug 13, 2024
View reviewed changes
Comment thread beacon_node/network/src/network_beacon_processor/rpc_methods.rs
@@ -320,14 +320,53 @@ impl<T: BeaconChainTypes> NetworkBeaconProcessor<T> {
pub fn handle_data_columns_by_root_request(

@realbigsean realbigsean Aug 13, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this use terminate_response_stream like we use in other similar methods?

@dapplion dapplion Aug 13, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in aa0b903

realbigsean
realbigsean reviewed Aug 13, 2024
View reviewed changes
Comment thread beacon_node/network/src/network_beacon_processor/rpc_methods.rs
self.log,
"Received DataColumnsByRoot Request";
"peer" => %peer_id,
"request" => ?request.group_by_ordered_block_root(),

@realbigsean realbigsean Aug 13, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the benefit of ordering by block roots in this log?

@dapplion dapplion Aug 13, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I introduced group_by_ordered_block_root originally to handle the reprocessing of requests. I left it here as it produces a more succint output. The raw request repeats the root for every column. Usually peers requests multiple indexes for the same root, so the output of this is nicer.

realbigsean
realbigsean approved these changes Aug 13, 2024
View reviewed changes

@realbigsean realbigsean left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small suggestion and one question but looks good

@dapplion dapplion changed the base branch from peerdas-network-processor to unstable August 13, 2024 21:37
@dapplion dapplion force-pushed the peerdas-network-rpc-handler branch from 25c1647 to 34f796d Compare August 13, 2024 21:47
@dapplion

dapplion commented Aug 13, 2024

Copy link
Copy Markdown
Collaborator Author

@jimmygchen I have forced push a rebase of this branch against unstable, as the commit from #6238 had leaked into this PR

@dapplion dapplion added ready-for-review The code is ready for review and removed do-not-merge labels Aug 13, 2024
@realbigsean

realbigsean commented Aug 15, 2024

Copy link
Copy Markdown
Member

@mergify queue

@mergify

mergify Bot commented Aug 15, 2024 •
edited
Loading

Copy link
Copy Markdown

queue

🛑 The pull request has been removed from the queue default

Details

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@realbigsean

realbigsean commented Aug 15, 2024

Copy link
Copy Markdown
Member

@mergify refresh

@mergify

mergify Bot commented Aug 15, 2024

Copy link
Copy Markdown

refresh

✅ Pull request refreshed

@realbigsean

realbigsean commented Aug 15, 2024

Copy link
Copy Markdown
Member

@mergify queue

@mergify

mergify Bot commented Aug 15, 2024

Copy link
Copy Markdown

queue

🛑 The pull request has been removed from the queue default

Details

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@realbigsean

realbigsean commented Aug 15, 2024

Copy link
Copy Markdown
Member

@mergify dequeue

@mergify

mergify Bot commented Aug 15, 2024

Copy link
Copy Markdown

dequeue

☑️ The pull request is not queued

@realbigsean

realbigsean commented Aug 15, 2024

Copy link
Copy Markdown
Member

@mergify queue

@mergify

mergify Bot commented Aug 15, 2024

Copy link
Copy Markdown

queue

🛑 The pull request has been removed from the queue default

Details

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@realbigsean

realbigsean commented Aug 15, 2024

Copy link
Copy Markdown
Member

@mergify requeue

@mergify

mergify Bot commented Aug 15, 2024

Copy link
Copy Markdown

requeue

✅ This pull request will be re-embarked automatically

Details

The followup queue command will be automatically executed to re-embark the pull request

@mergify

mergify Bot commented Aug 15, 2024 •
edited
Loading

Copy link
Copy Markdown

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at 6566705

@mergify mergify Bot merged commit 6566705 into unstable Aug 15, 2024
@mergify mergify Bot deleted the peerdas-network-rpc-handler branch August 15, 2024 21:15
AgeManning pushed a commit to AgeManning/lighthouse that referenced this pull request Sep 3, 2024
@dapplion @AgeManning
Implement PeerDAS RPC handlers (sigp#6237)
e7b1d5e 
* Implement PeerDAS RPC handlers

* use terminate_response_stream

* Merge branch 'unstable' of https://github.com/sigp/lighthouse into peerdas-network-rpc-handler

* cargo fmt
chong-he pushed a commit to chong-he/lighthouse that referenced this pull request Nov 26, 2024
@dapplion @chong-he
Implement PeerDAS RPC handlers (sigp#6237)
45689dd 
* Implement PeerDAS RPC handlers

* use terminate_response_stream

* Merge branch 'unstable' of https://github.com/sigp/lighthouse into peerdas-network-rpc-handler

* cargo fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@realbigsean realbigsean realbigsean approved these changes

@jimmygchen jimmygchen Awaiting requested review from jimmygchen

Assignees

No one assigned

Labels

das Data Availability Sampling das-unstable-merge ready-for-review The code is ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dapplion @jimmygchen @realbigsean