Skip to content

Support for building github desktop offline - #562

Closed
Lunarequest wants to merge 48 commits into
shiftkey:linuxfrom
Lunarequest:linux
Closed

Support for building github desktop offline#562
Lunarequest wants to merge 48 commits into
shiftkey:linuxfrom
Lunarequest:linux

Conversation

@Lunarequest

Copy link
Copy Markdown

Assuming a offline yarn mirror has been setup like here. By setting the env var OFFLINE to 1 you can build with offline. This is useful for situations where internet access is not possible, such as in a flatpak or in the Fedora build infrastructure.

shiftkey and others added 30 commits July 19, 2021 09:30
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
* Theme Scrollbars

Updated scrollbars to match windows webkit styling for both light and dark mode

* Update _scroll.scss

Separating linux from win32 reference, in case we want to adjust for the future and not impact the other

* Updated Scroll Color and Docs

Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
Reduce errors produced in terminal from debian package installations by testing for existence of symlink prior to executing unlink
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
dependabot Bot and others added 17 commits July 19, 2021 09:30
Bumps [electron-builder](https://github.com/electron-userland/electron-builder) from 22.9.1 to 22.10.5.
- [Release notes](https://github.com/electron-userland/electron-builder/releases)
- [Changelog](https://github.com/electron-userland/electron-builder/blob/master/CHANGELOG.md)
- [Commits](electron-userland/electron-builder@v22.9.1...v22.10.5)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [electron-builder](https://github.com/electron-userland/electron-builder) from 22.10.5 to 22.11.1.
- [Release notes](https://github.com/electron-userland/electron-builder/releases)
- [Changelog](https://github.com/electron-userland/electron-builder/blob/master/CHANGELOG.md)
- [Commits](electron-userland/electron-builder@v22.10.5...v22.11.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [electron-builder](https://github.com/electron-userland/electron-builder) from 22.11.1 to 22.11.5.
- [Release notes](https://github.com/electron-userland/electron-builder/releases)
- [Changelog](https://github.com/electron-userland/electron-builder/blob/master/CHANGELOG.md)
- [Commits](electron-userland/electron-builder@v22.11.1...v22.11.5)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…hiftkey#506)

* bump package
* rename all dugite usages to @shiftkey/dugite
* update build script to use new package
Bumps [electron-builder](https://github.com/electron-userland/electron-builder) from 22.11.5 to 22.11.7.
- [Release notes](https://github.com/electron-userland/electron-builder/releases)
- [Changelog](https://github.com/electron-userland/electron-builder/blob/master/CHANGELOG.md)
- [Commits](electron-userland/electron-builder@v22.11.5...v22.11.7)

---
updated-dependencies:
- dependency-name: electron-builder
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* drop explicit window icon on Linux
* drop old icon used in app window
* regenerate smaller icons from new 256px source
Co-Authored-By: nullrequest <30698906+advaithm@users.noreply.github.com>
Bumps [electron-packager](https://github.com/electron/electron-packager) from 15.2.0 to 15.3.0.
- [Release notes](https://github.com/electron/electron-packager/releases)
- [Changelog](https://github.com/electron/electron-packager/blob/main/NEWS.md)
- [Commits](electron/packager@v15.2.0...v15.3.0)

---
updated-dependencies:
- dependency-name: electron-packager
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Comment thread script/post-install.ts Outdated
Co-authored-by: Brendan Forster <brendan@github.com>
@Lunarequest

Copy link
Copy Markdown
Author

I have no idea why the windows ci broke, it seems like some sort of network issue?

@Lunarequest

Lunarequest commented Jul 22, 2021

Copy link
Copy Markdown
Author

@shiftkey would you mind reviewing this pr in its altered state?

@shiftkey

shiftkey commented Jul 22, 2021

Copy link
Copy Markdown
Owner

@AdvaithM I've held off on review because I wanted to suggest a different approach, and I've not had time to prove it out. Instead of this pattern:

  let result
   if (isOffline()) {
     result = spawnSync(
       'node',
       [path, '--offline', '--cwd', 'app', 'install', '--force'],
       options
     )
   } else {
     result = spawnSync(
       'node',
       [path, '--cwd', 'app', 'install', '--force'],
       options
     )
   }

I wanted to see if we could avoid duplicating the arguments and instead insert the relevant offline parameter at the appropriate place:

  const installArgs = [path, '--cwd', 'app', 'install', '--force']
  if (isOffline()) {
    installArgs.splice(1, 0, '--offline')
  }

  let result = spawnSync('node', installArgs, options)

Tomorrow I should have some more bandwidth, but hopefully that helps with some feedback in the meantime...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants