Skip to content

escape paths with regex over quotes in flatpaks - #558

Merged
shiftkey merged 4 commits into
shiftkey:linuxfrom
Lunarequest:linux
Jul 19, 2021
Merged

escape paths with regex over quotes in flatpaks#558
shiftkey merged 4 commits into
shiftkey:linuxfrom
Lunarequest:linux

Conversation

@Lunarequest

@Lunarequest Lunarequest commented Jul 17, 2021

Copy link
Copy Markdown

For some reason this stops an intermittent issue where the path supplied to the editor binary would be append with a ".

@Lunarequest Lunarequest mentioned this pull request Jul 17, 2021
Closed
7 tasks
shiftkey
shiftkey reviewed Jul 18, 2021
View reviewed changes
Comment thread app/src/lib/helpers/linux.ts Outdated
shiftkey
shiftkey approved these changes Jul 19, 2021
View reviewed changes

@shiftkey shiftkey left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit puzzled by this one and why quoting isn't working, but given it's only for Flatpak and there are tests I'm good to take it in. Thanks for the fix @AdvaithM!

@shiftkey
shiftkey merged this pull request into shiftkey:linux Jul 19, 2021
shiftkey pushed a commit that referenced this pull request Jul 19, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
d8d8648
@Lunarequest

Lunarequest commented Jul 19, 2021

Copy link
Copy Markdown
Author

I'm a bit puzzled by this one and why quoting isn't working, but given it's only for Flatpak and there are tests I'm good to take it in. Thanks for the fix @AdvaithM!

I suspect there is a bug in flatpak-spawn but I'm not to sure on how to debug it

shiftkey pushed a commit that referenced this pull request Jul 19, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
6b576be
shiftkey pushed a commit that referenced this pull request Jul 22, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
715dca6
shiftkey pushed a commit that referenced this pull request Aug 14, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
de49157
shiftkey pushed a commit that referenced this pull request Aug 20, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
e9b0ae4
shiftkey pushed a commit that referenced this pull request Aug 24, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
ffcd94a
shiftkey pushed a commit that referenced this pull request Aug 24, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
573547b
shiftkey pushed a commit that referenced this pull request Aug 24, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
afb3846
shiftkey pushed a commit that referenced this pull request Aug 24, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
0c76b33
shiftkey pushed a commit that referenced this pull request Aug 29, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
6aada91
shiftkey pushed a commit that referenced this pull request Sep 1, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
d7898fb
shiftkey pushed a commit that referenced this pull request Sep 5, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
29bf256
shiftkey pushed a commit that referenced this pull request Sep 5, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
3c6fa8d
shiftkey pushed a commit that referenced this pull request Sep 5, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
f37b969
shiftkey pushed a commit that referenced this pull request Sep 30, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
81d9c38
shiftkey pushed a commit that referenced this pull request Oct 3, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
947f541
shiftkey pushed a commit that referenced this pull request Oct 7, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
e4af842
shiftkey pushed a commit that referenced this pull request Feb 22, 2022
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
434a383
shiftkey pushed a commit that referenced this pull request Feb 22, 2022
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
6340df6
shiftkey pushed a commit that referenced this pull request Feb 22, 2022
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
8abb16e
shiftkey pushed a commit that referenced this pull request Feb 22, 2022
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
a8913fd
shiftkey pushed a commit that referenced this pull request Feb 22, 2022
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
c4b450d
shiftkey pushed a commit that referenced this pull request Mar 12, 2022
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
9a041ab
shiftkey pushed a commit that referenced this pull request Apr 3, 2022
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
a8878fb
shiftkey pushed a commit that referenced this pull request Apr 3, 2022
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
a3d16d1
shiftkey pushed a commit that referenced this pull request Apr 3, 2022
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
ed73994
shiftkey pushed a commit that referenced this pull request Apr 3, 2022
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
7540a4f
shiftkey pushed a commit that referenced this pull request Apr 3, 2022
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
1fe3896
shiftkey pushed a commit that referenced this pull request Apr 3, 2022
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
5475cd5
shiftkey pushed a commit that referenced this pull request Apr 3, 2022
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
c4f5766
shiftkey pushed a commit that referenced this pull request Apr 8, 2022
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
7a09c97
shiftkey pushed a commit that referenced this pull request Apr 15, 2022
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
3080bd3
shiftkey pushed a commit that referenced this pull request Apr 15, 2022
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
0b15bda
shiftkey pushed a commit that referenced this pull request Apr 15, 2022
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
8d4b4d9
shiftkey pushed a commit that referenced this pull request Apr 15, 2022
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
6f4eb87
shiftkey pushed a commit that referenced this pull request Apr 15, 2022
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
cb0e9e3
shiftkey pushed a commit that referenced this pull request Apr 21, 2022
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
1f363b2
shiftkey pushed a commit that referenced this pull request Apr 21, 2022
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
4d850f4
shiftkey pushed a commit that referenced this pull request Apr 21, 2022
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
00f4a8f
shiftkey pushed a commit that referenced this pull request Apr 27, 2022
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
7766548
shiftkey pushed a commit that referenced this pull request Apr 27, 2022
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
133ddfc
shiftkey pushed a commit that referenced this pull request Apr 27, 2022
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
1a93f36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shiftkey shiftkey shiftkey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Lunarequest @shiftkey