Extend SQL grammar to allow for empty OVER() - #8
Merged
Conversation
Fixes #33759 Make PARTITION BY optional by extracting it into a `partition_by_clause` sub-rule referenced as `?` from `over_partition`, so all four shapes parse: empty `OVER()`, order-only, partition-only, and the original partition+order form.
sgress454
reviewed
May 13, 2026
sgress454
left a comment
sgress454
left a comment
Owner
There was a problem hiding this comment.
LGTM, mind adding regression tests for the cases this fixes?
juan-fdz-hawa
pushed a commit
to fleetdm/fleet
that referenced
this pull request
May 14, 2026
Resolves #33759 Bumps Fleet's `@sgress454/node-sql-parser` to the version that includes sgress454/node-sql-parser#8, with fixes for #33759.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33759
Make PARTITION BY optional by extracting it into a
partition_by_clausesub-rule referenced as?fromover_partition, so all four shapes parse: emptyOVER(), order-only, partition-only, and the original partition+order form.