Skip to content

bump node-sql-parser fork - #45472

Merged
juan-fdz-hawa merged 1 commit into
mainfrom
sgress454/bump-node-sql-parser-to-5.4.0-fork.2
May 14, 2026
Merged

bump node-sql-parser fork#45472
juan-fdz-hawa merged 1 commit into
mainfrom
sgress454/bump-node-sql-parser-to-5.4.0-fork.2

Conversation

@sgress454

@sgress454 sgress454 commented May 14, 2026

Copy link
Copy Markdown
Contributor

Related issue: Resolves #33759

Bumps Fleet's @sgress454/node-sql-parser to the version that includes sgress454/node-sql-parser#8, with fixes for #33759.

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated internal dependency version for improved compatibility.

Review Change Stack

Copilot AI review requested due to automatic review settings May 14, 2026 14:22

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@sgress454

Copy link
Copy Markdown
Contributor Author

@juan-fdz-hawa if you pull this branch, make deps, make generate-dev and then verify that your changes are in there, then you can 👍 and merge it to close the loop.

@coderabbitai

coderabbitai Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 066074bd-16c8-4e86-8c09-02be2b109b34

📥 Commits

Reviewing files that changed from the base of the PR and between 057e161 and 3ed30af.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json

Walkthrough

This PR updates the @sgress454/node-sql-parser dependency from version 5.4.0-fork.1 to 5.4.0-fork.2 in package.json. The update addresses incorrect SQL validation that was flagging valid queries containing window functions (such as LEAD()) as syntax errors in the query editor, despite those queries executing successfully when run as live queries. The dependency bump includes a minor formatting adjustment to the package.json file.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'bump node-sql-parser fork' directly and clearly describes the main change in the pull request: updating the dependency version.
Description check ✅ Passed The PR description includes the related issue and explains the purpose clearly, though it lacks completion of the checklist template items.
Linked Issues check ✅ Passed The code changes directly address issue #33759 by bumping the node-sql-parser fork to include the fix for window function validation errors.
Out of Scope Changes check ✅ Passed All changes are limited to a single dependency version update in package.json, which is directly scoped to resolving the linked issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sgress454/bump-node-sql-parser-to-5.4.0-fork.2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Bumps the @sgress454/node-sql-parser fork from 5.4.0-fork.1 to 5.4.0-fork.2 to pick up upstream PR #8, which fixes the false-positive syntax error flagged by the query editor for valid SQL using window functions (e.g. LEAD() OVER ()).

Changes:

  • Bump @sgress454/node-sql-parser dependency to 5.4.0-fork.2 in package.json.
  • Update the corresponding yarn.lock entry (version, resolved URL, integrity hash).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
package.json Updates the @sgress454/node-sql-parser dependency version to 5.4.0-fork.2.
yarn.lock Updates the lockfile entry to match the new fork version, registry URL, and integrity hash.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented May 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.71%. Comparing base (057e161) to head (3ed30af).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #45472   +/-   ##
=======================================
  Coverage   66.71%   66.71%           
=======================================
  Files        2734     2734           
  Lines      218824   218824           
  Branches    10820    10820           
=======================================
  Hits       145979   145979           
  Misses      59625    59625           
  Partials    13220    13220           
Flag Coverage Δ
frontend 55.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juan-fdz-hawa
juan-fdz-hawa merged commit 4f8737e into main May 14, 2026
25 checks passed
@juan-fdz-hawa
juan-fdz-hawa deleted the sgress454/bump-node-sql-parser-to-5.4.0-fork.2 branch May 14, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI: Valid query with window function is incorrectly flagged with a syntax error

3 participants