Repository navigation
Conversation
jiapingW
requested review from
FlamingoPg,
FrankLeeeee,
shuaills and
sleepcoo
as code owners
November 1, 2026 10:33
This was referenced Nov 1, 2026
6 tasks
Collaborator
|
If HTTP times out before publication finishes, cleanup can run before the objects exist. The server can then publish them with nobody left to free them. Can we handle this on the server and add a delayed-publication test? |
curnane-lab
approved these changes
Nov 5, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Offline preparation currently loads SGLang's ModelRunner and maintains private scheduler/model patches inside the client. Replace that implementation with a CPU client using HTTP capture requests and Mooncake, so
prepare_hidden_states.pyno longer imports SGLang or loads target model weights.--server-urlsidentifies independently launched plugin servers. Before sending prompts, the client validates their model, capture method and ordered layer IDs using part 1's metadata. Preserve the algorithm-owned feature schemas, compression, stable sample IDs, resume and CPU sharding; publish files atomically and release feature objects after writers finish. Remove the old local inference backend and replace its tests. Move TP/attention settings to the server in the offline examples and AMD walkthrough.Validation: full
pre-commit run --all-filespassed. H20 offline/client/schema/architecture regression: 44 passed, 1 skipped (standalone Mooncake-master opt-in). Adds a live plugin-to-files numerical/resume test to the existing GPU gate. The complete stack previously passed that live test and the three other GPU capture tests.Includes the shared CI dependency-test fix from #1063 via forward merges. All 8 CI dependency tests passed on Linux for this layer; the feature diff is unchanged.
Review and merge order:
Each PR compares against the previous layer. Shared follow-up fixes are merged forward without rewriting published history. After merging a predecessor, retarget the next PR to
main; if using squash merges, rebase the remaining stack before retargeting. The GPU workflow filters PRs targetingmain, so later layers receive that CI run when retargeted. Lint runs on every layer.This stack replaces #1062. Its combined feature changes match #1062 plus the lint fix; subsequent CI regression fixes are shared across the stack.