Repository navigation
[1/4] capture: prepare the native plugin runtime and CI server - #1063
Merged
Merged
Conversation
This was referenced Nov 1, 2026
6 tasks
curnane-lab
approved these changes
Nov 5, 2026
Collaborator
|
LGTM. The separate capture env and native-plugin CI make sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capture CI currently exercises a patched server, and plugin server metadata lacks the capture method and layer IDs needed to validate offline requests. This PR makes CI launch the native plugin in a separate cached
sf-captureenvironment at SGLang commitc757c4bb7c55d1eb69fdb2bdc6e6fb8507acb7a0and exposes that capture contract through/server_info.It also keeps malformed NVLink free messages from discarding later valid messages, moves sink coverage to the plugin implementation, and updates the native scheduler fixture for the selected revision. Training dependencies remain on their existing versions until the final PR; the server dependency environment is isolated.
Validation: full
pre-commit run --all-filespassed. H20 plugin/sink regression: 60 passed, 1 skipped because the older training environment lacks native extension APIs. The native integration is exercised again in part 4 with the pinned SGLang source. Full GitHub GPU CI may still be queued.Follow-up CI fix (
c19f6b05): update the dependency-cache test fixture for bothsfandsf-capture, exercise the current restore loop, verify separate contents and preserved symlinks, and require capture installation before saving the cache. All 8 CI dependency tests passed on Linux for each stack layer; the changed-file pre-commit checks also passed. Only the regression test changed.Review and merge order:
Each PR compares against the previous layer. Shared follow-up fixes are merged forward without rewriting published history. After merging a predecessor, retarget the next PR to
main; if using squash merges, rebase the remaining stack before retargeting. The GPU workflow filters PRs targetingmain, so later layers receive that CI run when retargeted. Lint runs on every layer.This stack replaces #1062. Its combined feature changes match #1062 plus the lint fix; subsequent CI regression fixes are shared across the stack.