[Closes #258] Add code coverage reporting to codecov#261
[Closes #258] Add code coverage reporting to codecov#261rahulpuroht wants to merge 3 commits intosendgrid:masterfrom
Conversation
|
We can’t merge your PR without the CLA being signed. [ ] Sign the CLA before November 3rd Then we will comment with a link to get your shirt! |
|
Hello, Signed the CLA for this Pull Request.Please send a link to get my shirt :) |
|
Thanks @rahulpuroht! Here is the link, enjoy! |
mbernier
left a comment
There was a problem hiding this comment.
There is something happening in travis that I believe is related to this change, can you please look into this?
/home/travis/.rvm/rubies/ruby-2.4.1/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in `require': cannot load such file -- test_helper (LoadError)
from /home/travis/.rvm/rubies/ruby-2.4.1/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in `require'
from /home/travis/build/sendgrid/sendgrid-ruby/test/sendgrid/test_sendgrid-ruby.rb:2:in `<top (required)>'
from /home/travis/.rvm/rubies/ruby-2.4.1/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in `require'
from /home/travis/.rvm/rubies/ruby-2.4.1/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in `require'
from /home/travis/.rvm/gems/ruby-2.4.1@global/gems/rake-12.0.0/lib/rake/rake_test_loader.rb:15:in `block in <main>'
from /home/travis/.rvm/gems/ruby-2.4.1@global/gems/rake-12.0.0/lib/rake/rake_test_loader.rb:4:in `select'
from /home/travis/.rvm/gems/ruby-2.4.1@global/gems/rake-12.0.0/lib/rake/rake_test_loader.rb:4:in `<main>'
rake aborted!
Command failed with status (1): [ruby -w -I"lib:test" -I"/home/travis/.rvm/gems/ruby-2.4.1@global/gems/rake-12.0.0/lib" "/home/travis/.rvm/gems/ruby-2.4.1@global/gems/rake-12.0.0/lib/rake/rake_test_loader.rb" "test/sendgrid/test_helper.rb" "test/sendgrid/test_sendgrid-ruby.rb" "test/sendgrid/helpers/mail/test_category.rb" "test/sendgrid/helpers/mail/test_email.rb" "test/sendgrid/helpers/mail/test_mail.rb" "test/sendgrid/helpers/mail/test_personalizations.rb" ]
/home/travis/.rvm/gems/ruby-2.4.1@global/gems/rake-12.0.0/exe/rake:27:in `<top (required)>'
/home/travis/.rvm/gems/ruby-2.4.1/bin/ruby_executable_hooks:15:in `eval'
/home/travis/.rvm/gems/ruby-2.4.1/bin/ruby_executable_hooks:15:in `<main>'
Tasks: TOP => test
(See full trace by running task with --trace)
|
I had to move the code from |
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
=========================================
Coverage ? 19.75%
=========================================
Files ? 4
Lines ? 243
Branches ? 0
=========================================
Hits ? 48
Misses ? 195
Partials ? 0Continue to review full report at Codecov.
|
af89726 to
d2ad537
Compare
|
@clee Hey can you please look into it and suggest why it still showing this errors in Travis. |
|
Hi @rahulpuroht, Those failures are not related to your work. I will still be able to merge this without those tests passing. Thank you! With Best Regards, Elmer |
|
@thinkingserious this got the |
Inspired by the changes in sendgrid#261 Closes sendgrid#59.
Inspired by the changes in sendgrid/sendgrid-ruby#261 Closes sendgrid#59.
cdbfe92 to
4092c4f
Compare
|
Duplicates #368 |
Fixes
Checklist
Short description of what this PR does:
If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.