Skip to content

[Closes #258] Add code coverage reporting to codecov#261

Closed
rahulpuroht wants to merge 3 commits intosendgrid:masterfrom
rahulpuroht:rahulpuroht-patch-1
Closed

[Closes #258] Add code coverage reporting to codecov#261
rahulpuroht wants to merge 3 commits intosendgrid:masterfrom
rahulpuroht:rahulpuroht-patch-1

Conversation

@rahulpuroht
Copy link

@rahulpuroht rahulpuroht commented Oct 30, 2017

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • This PR add code coverage reporting and integrates it with codecov

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 30, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 30, 2017

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 1, 2017
@thinkingserious
Copy link
Contributor

@rahulpuroht

We can’t merge your PR without the CLA being signed.

[ ] Sign the CLA before November 3rd
[ ] Tag @mbernier and @thinkingserious to let us know it is signed

Then we will comment with a link to get your shirt!

@rahulpuroht
Copy link
Author

rahulpuroht commented Nov 4, 2017

Hello,

@mbernier @thinkingserious

Signed the CLA for this Pull Request.Please send a link to get my shirt :)

@thinkingserious
Copy link
Contributor

Thanks @rahulpuroht!

Here is the link, enjoy!

Copy link

@mbernier mbernier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is something happening in travis that I believe is related to this change, can you please look into this?

/home/travis/.rvm/rubies/ruby-2.4.1/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in `require': cannot load such file -- test_helper (LoadError)
	from /home/travis/.rvm/rubies/ruby-2.4.1/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /home/travis/build/sendgrid/sendgrid-ruby/test/sendgrid/test_sendgrid-ruby.rb:2:in `<top (required)>'
	from /home/travis/.rvm/rubies/ruby-2.4.1/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /home/travis/.rvm/rubies/ruby-2.4.1/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /home/travis/.rvm/gems/ruby-2.4.1@global/gems/rake-12.0.0/lib/rake/rake_test_loader.rb:15:in `block in <main>'
	from /home/travis/.rvm/gems/ruby-2.4.1@global/gems/rake-12.0.0/lib/rake/rake_test_loader.rb:4:in `select'
	from /home/travis/.rvm/gems/ruby-2.4.1@global/gems/rake-12.0.0/lib/rake/rake_test_loader.rb:4:in `<main>'
rake aborted!
Command failed with status (1): [ruby -w -I"lib:test" -I"/home/travis/.rvm/gems/ruby-2.4.1@global/gems/rake-12.0.0/lib" "/home/travis/.rvm/gems/ruby-2.4.1@global/gems/rake-12.0.0/lib/rake/rake_test_loader.rb" "test/sendgrid/test_helper.rb" "test/sendgrid/test_sendgrid-ruby.rb" "test/sendgrid/helpers/mail/test_category.rb" "test/sendgrid/helpers/mail/test_email.rb" "test/sendgrid/helpers/mail/test_mail.rb" "test/sendgrid/helpers/mail/test_personalizations.rb" ]
/home/travis/.rvm/gems/ruby-2.4.1@global/gems/rake-12.0.0/exe/rake:27:in `<top (required)>'
/home/travis/.rvm/gems/ruby-2.4.1/bin/ruby_executable_hooks:15:in `eval'
/home/travis/.rvm/gems/ruby-2.4.1/bin/ruby_executable_hooks:15:in `<main>'
Tasks: TOP => test
(See full trace by running task with --trace)

@clee
Copy link

clee commented Feb 12, 2018

I had to move the code from test_helper.rb to test_sendgrid-ruby.rb to get this to work, but it didn't break any tests when I did. @rahulpuroht, can you please resubmit with the code moved over?

@clee clee added triaged and removed status: code review request requesting a community code review or review from Twilio triaged labels Feb 12, 2018
@codecov
Copy link

codecov bot commented Feb 16, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@c0ac8b2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #261   +/-   ##
=========================================
  Coverage          ?   19.75%           
=========================================
  Files             ?        4           
  Lines             ?      243           
  Branches          ?        0           
=========================================
  Hits              ?       48           
  Misses            ?      195           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0ac8b2...d2ad537. Read the comment docs.

@thinkingserious thinkingserious added status: code review request requesting a community code review or review from Twilio difficulty: easy fix is easy in difficulty type: twilio enhancement feature request on Twilio's roadmap and removed status: code review complete labels Feb 27, 2018
@rahulpuroht
Copy link
Author

@clee Hey can you please look into it and suggest why it still showing this errors in Travis.

@thinkingserious
Copy link
Contributor

Hi @rahulpuroht,

Those failures are not related to your work. I will still be able to merge this without those tests passing.

Thank you!

With Best Regards,

Elmer

@benpatterson
Copy link

@thinkingserious this got the hacktoberfest label put on it recently, but it sounded like this was going to be merged soon. Do you guys still need help setting up CodeCov?

jamietanna added a commit to jamietanna/sendgrid-ruby that referenced this pull request Oct 13, 2018
jamietanna added a commit to jamietanna/ruby-http-client that referenced this pull request Oct 13, 2018
@childish-sambino childish-sambino force-pushed the master branch 13 times, most recently from cdbfe92 to 4092c4f Compare June 3, 2020 19:03
@childish-sambino
Copy link
Contributor

Duplicates #368

@childish-sambino childish-sambino added status: duplicate duplicate issue and removed difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: twilio enhancement feature request on Twilio's roadmap labels Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: duplicate duplicate issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants