Skip to content

Revert clap update - #78

Merged
bors[bot] merged 22 commits into
science-computing:masterfrom
matthiasbeyer:revert-clap-update
Nov 18, 2022
Merged

Revert clap update#78
bors[bot] merged 22 commits into
science-computing:masterfrom
matthiasbeyer:revert-clap-update

Conversation

@matthiasbeyer

@matthiasbeyer matthiasbeyer commented Nov 18, 2022

Copy link
Copy Markdown
Contributor

This reverts the clap update.

Closes #42

Please test before merging.

@matthiasbeyer
Revert "Bump clap from 4.0.22 to 4.0.26"
4d25d45 
This reverts commit c15dd7c.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Revert "Fix clippy: Remove unused ref"
4d659b4 
This reverts commit d69257d.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Revert "Fix clippy: Replace deref-ref"
8d18955 
This reverts commit 299a8f6.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Revert "Fix clippy: Remove deref-ref"
3722c7e 
This reverts commit 7403418.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Revert "Fix clippy: Replace manual copy with Option::copied()"
d0cd207 
This reverts commit 5e13c9a.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Revert "Fix clippy: Remove unneeded reference"
d0a918e 
This reverts commit 1464a37.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Revert "Fix clippy: Remove unused lifetimes"
55e70af 
This reverts commit d3a550c.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Revert "Fix clippy: Pass slice instead of reference"
fb01239 
This reverts commit 054eac1.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Revert "Fix clippy: Pass slice instead of reference"
a351fe9 
This reverts commit fc57a86.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Revert "Fix clippy: Remove unnecessary dereference"
16d8650 
This reverts commit 4734daa.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Revert "Remove unused import"
6962fb4 
This reverts commit 65a902b.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Revert "Rewrite date from string validator helper to be a value parser"
aea940d 
This reverts commit 20844b6.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Revert "Replace integer validators with value parser"
bf039f5 
This reverts commit 47ce837.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Revert "Rewrite env_pass_validator to be a value parser"
e2dc3ba 
This reverts commit 146e2a0.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Revert "Rewrite dir_exists_validator to be a value parser"
debbbc2 
This reverts commit 7ca2a33.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Revert "Add static lifetimes for helper fns"
4ef8802 
This reverts commit 184c74d.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Revert "Replace ArgMatches::is_present with ArgMatches::get_flag"
6b2dd4c 
This reverts commit 643ae41.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Revert "Rewrite value fetching"
4de1129 
This reverts commit a53f3bf.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Revert "Replace Arg::possible_values() with PossibleValueParser"
c3f51e7 
This reverts commit ec57c25.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Revert "Replace argument configuration with new functions"
5bf5a52 
This reverts commit 60d1278.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Revert "Remove lifetimes that are no longer necessary"
0d28e50 
This reverts commit 86ee2f9.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Revert "Update clap: 3 -> 4"
6827316 
This reverts commit 162b50a.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@christophprokop

christophprokop commented Nov 18, 2022

Copy link
Copy Markdown
Collaborator

these both work just fine

butido.pr78 build tree -I local:rh8-default -L 1.8.0
butido.pr78 build tree -I local:rh8-default -E DEBUG=1 -L 1.8.0

but not like this

butido.pr78 build tree -I local:rh8-default -E DEBUG=1 1.8.0
[2022-11-18T17:30:15Z ERROR butido::cli] Error during validation: 'Mismatch at 0: expect repeat at least 1 times, found 0 times' is not a key-value pair
error: Invalid value for '--env ...': Mismatch at 0: expect repeat at least 1 times, found 0 times

and this is new

butido.pr78 build tree -I local:rh8-default -E DEBUG=1 -- 1.8.0
this did not work in earlier builds
if we just have to end the option part with '--' it's fine with me

@christophprokop christophprokop mentioned this pull request Nov 18, 2022
Merged
@christophprokop

christophprokop commented Nov 18, 2022

Copy link
Copy Markdown
Collaborator

bors merge

@bors

bors Bot commented Nov 18, 2022

Copy link
Copy Markdown
Contributor

Build succeeded:

@bors
bors Bot merged commit acac31a into science-computing:master Nov 18, 2022
This was referenced Nov 18, 2022
Closed
Closed
@matthiasbeyer
matthiasbeyer deleted the revert-clap-update branch November 19, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CLI broken

2 participants

@matthiasbeyer @christophprokop