Update indicatif - #77
Merged
bors[bot] merged 2 commits intoNov 19, 2022
Merged
Conversation
Contributor
Author
|
Changes here should be tested, because |
matthiasbeyer
force-pushed
the
update-indicatif
branch
from
November 18, 2022 15:52
5613d56 to
4f760f0
Compare
Collaborator
Bumps [indicatif](https://github.com/console-rs/indicatif) from 0.16.2 to 0.17.2. - [Release notes](https://github.com/console-rs/indicatif/releases) - [Commits](console-rs/indicatif@0.16.2...0.17.2) --- updated-dependencies: - dependency-name: indicatif dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
So we need to adapt for the indicatif interface changes. First of all, `ProgressStyle::template()` returns a `Result` now, so we need to adapt `ProgressBars::bar()` to also return a `Result` type and adjust all uses of this function. Secondly, we do not need to `MultiBar::join()` anymore, which makes some future collecting less complex. Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
matthiasbeyer
force-pushed
the
update-indicatif
branch
from
November 19, 2022 07:57
9b8a7fe to
ceb195d
Compare
Collaborator
|
works! thank you! |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes and supersedes #74