Repository navigation
[gnuabi] Leave no core of the runtime when a program ends by a fault - #2643
Merged
Merged
Conversation
A core limit of 0 stops a core written to a file, not one the host pipes to a program: the runtime is not dumpable when it raises the program's signal. gnuabi_elf32 gives each of its programs 20 s. Change-Id: I2334211d54d68d78ea86d7898acca7ffdd86de30 Signed-off-by: AF52 <AF52@reden-emu.dev>
|
Builds of 2c877ea, kept until 2027-02-18:
Amberlith: skipped Not built: appimage (failure), appimage-cross (skipped), apple (failure) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix for pull requests' Linux AArch64 job: gnuabi_elf32's null-read program passes its 60 s there in some runs (#2489's and #2623's).
gnu_spawn_exitsets RLIMIT_CORE to 0 for "no core of the runtime", and a core that the host pipes to a program (a core_pattern of "|...") is made whatever that limit. The runtime now makes itself not dumpable first, which stops both.Testing: this job's own time for gnuabi_elf32 is the check, under a second if the cause is the piped core. That cause is inferred from the times above and from the kernel's rule; the runner's core_pattern was not read. On this machine (core_pattern "core") the test passes as before.