Repository navigation
[vk] Take a range's first page from its first word in the blk question - #2574
Draft
DraChimeraVee wants to merge 1 commit into
Draft
DraChimeraVee wants to merge 1 commit into
DraChimeraVee wants to merge 1 commit into
Conversation
rg_blk masked the bits before the first page in every word but the first: a range from inside a word was answered by pages before it and missed blk pages in its later words. Change-Id: Ifc62e06bc5da427e4c41f38aa02fee6af9020bdf Signed-off-by: AF52 <AF52@reden-emu.dev>
|
Builds of b83608d, kept until 2027-02-18:
Amberlith v1.0.0: 923 passed, 0 failed, 2 skipped, 0 crashed: every case of the baseline passes Not built: appimage-cross (skipped) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rg_blk masked the bits before a range's first page in every word but the first: a range that starts inside a word was answered by pages before it, and missed a blk page in the first bits of its later words, so vk_uma_read could take in place a range whose newer bytes are elsewhere. From an outside static audit of the tree (its F171). The page model is #1714's; this changes the one mask.
The mask moves to gpu/vk/uma_pages.h, as uma_budget.h holds the budget's arithmetic, so a test reaches it without a device.
Testing, on main 3abdb88 with the other branches of this audit applied: