Skip to content

fix(trends): call the range-average card what it is, below the range it averages - #2901

Open
UtkuDenizAltiok wants to merge 1 commit into
ryanbr:mainfrom
UtkuDenizAltiok:fix/trends-window-average-label
Open

UtkuDenizAltiok wants to merge 1 commit into
ryanbr:mainfrom
UtkuDenizAltiok:fix/trends-window-average-label

Conversation

@UtkuDenizAltiok

Copy link
Copy Markdown

What was wrong

Trends opens with the week digest (this week's Charge / Effort / Rest), then a card titled "Week in review" whose numbers are the means over the range window selected below it (3M by default). So the screen showed two different "this week" figures a few lines apart. In the demo data: the digest's Charge 50, then the card's 41, which was the 90-day mean.

The fix

The card now sits directly below the range control and is titled "Average" (overline unchanged: Charge · Effort · Rest), so it reads as the average of the range the wearer just chose. The digest at the top keeps the "Week in review" name it actually describes. Values, window resolution and the card itself are unchanged.

Both platforms, same order and title. Reuses strings that already ship in every locale (Apple "Average", Android explore_average), so no translation changes.

Verification

  • i18n_audit.py --ci upstream/main passes; doc_comment_lint.py clean.
  • iOS change: the card call moves below rangeBar and the header literal changes; Android change: the WeekInReviewCard item moves below the range control item and its header uses explore_average. CI's App build and Android jobs compile both.

🤖 Generated with Claude Code

…it averages

Trends opens with the week digest (this week's Charge / Effort / Rest),
then a card titled "Week in review" whose numbers are the means over the
range window selected BELOW it (3M by default). So the screen showed two
different "this week" figures a few lines apart: in the demo data, the
digest's Charge 50 and the card's 41, which was the 90-day mean.

The card now sits directly below the range control and is titled
"Average" (overline unchanged: Charge · Effort · Rest), so it reads as
the average of the range the wearer just chose. The digest at the top
keeps the "Week in review" name it actually describes. Values, the
window resolution and the card itself are unchanged.

Both platforms, same order and title. Reuses strings that already ship
in every locale (Apple "Average", Android explore_average), so no
translation changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
UtkuDenizAltiok added a commit to UtkuDenizAltiok/noop that referenced this pull request Nov 5, 2026
Tree is exactly 4a6a22c: upstream/main + every open app PR + Simple mode
(Today, More, Sleep, Trends) + ryanbr#2897 ryanbr#2898 ryanbr#2899 ryanbr#2900 ryanbr#2901 (the ryanbr#2896
swipe fix is already inside Simple mode) + the parity refresh. Recorded
as a merge over the previous stack so the branch moves forward without
rewriting history.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
UtkuDenizAltiok added a commit to UtkuDenizAltiok/noop that referenced this pull request Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant