Skip to content

test(formatter): cover conflict and network inference #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
overtrue wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −0
Draft

test(formatter): cover conflict and network inference #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions crates/cli/src/output/formatter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,29 @@ mod tests {
assert_eq!(details.suggestion.as_deref(), Some(USAGE_SUGGESTION));
}

#[test]
fn test_error_descriptor_from_message_infers_conflict() {
let descriptor = ErrorDescriptor::from_message("Destination exists at target path");
let json = descriptor.to_json_output();

let details = json.details.expect("details should be present");
assert_eq!(details.error_type, "conflict");
assert!(!details.retryable);
assert_eq!(details.suggestion.as_deref(), Some(CONFLICT_SUGGESTION));
}

#[test]
fn test_error_descriptor_from_message_infers_retryable_network_error() {
let descriptor =
ErrorDescriptor::from_message("Service temporarily unavailable while connecting");
let json = descriptor.to_json_output();

let details = json.details.expect("details should be present");
assert_eq!(details.error_type, "network_error");
assert!(details.retryable);
assert_eq!(details.suggestion.as_deref(), Some(NETWORK_SUGGESTION));
}

#[test]
fn test_error_with_suggestion_overrides_default_hint() {
let descriptor = ErrorDescriptor::from_code(
Expand Down