test(formatter): cover conflict and network inference#124
Draft
test(formatter): cover conflict and network inference#124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change adds focused formatter tests for two message-inference branches introduced by the recent structured error handling work: conflict classification and retryable network classification.
Without these assertions, the formatter coverage only exercised not-found and usage inference from free-form messages, leaving recent conflict and transient-network heuristics unguarded against regression.
Root Cause
The formatter infers JSON error metadata from raw error strings, but the unit tests did not cover the branches that map messages containing destination conflicts or temporary service/network failures.
Fix
Add two unit tests in
crates/cli/src/output/formatter.rsthat assert:error_type = "conflict", are not retryable, and carry the conflict suggestionerror_type = "network_error", are retryable, and carry the network suggestionValidation
cargo test -p rustfs-cli output::formatter::testscargo fmt --all --checkcargo clippy --workspace -- -D warningscargo test --workspaceNote
make pre-commitcould not be run because this checkout does not contain aMakefileor apre-committarget onorigin/main.