Repository navigation
Rollup of 8 pull requests - #164132
Merged
Merged
Rollup of 8 pull requests#164132
Conversation
…match fixed misleading suggestions of adding a return and semicolon expression to an expression already in return position by adding a return position check. fixed duplicate emission of error 277 by de-duplicateing the suggestion `suggest_missing_break_or_return_expr`, where a failed normalization leads to E277
Constants::new() built a table of 2^n for every n in -(2 << 15)..=(2 << 15), plus a second table of 2^(n-1) for half_ulp, separately for each float type. The size of 2^n grows with |n|, so each table took 512 MiB. The unit tests use f32 and f64 and peak at 2.1 GiB, which gets them OOM-killed on test-armhf-gnu's 1 GiB qemu machine. Keep a single table shared by all float types, covering only the exponents decode() can produce for f64, and look up half a ULP as the next power of two down instead of keeping a second table. The unit tests now peak at 15 MiB.
Outputs, where unit type is implicit default, did participate in the deduction. Identify unit type as irrelevant for the deduction as an optimization.
```
help: there is a method `bag` with a similar name, but with different arguments
--> $DIR/suggest-methods.rs:9:5
|
LL | trait FooT {
LL | fn bag(&self);
| ^^^^^^^^^^^^^^
```
Co-authored-by: adwin <52573298+adwinwhite@users.noreply.github.com>
The error messages produced by libloading 0.9 are different than those of libloading 0.8. The error message expected for GNU hosts changed in the same fashion and was updated in 7672b83 alongside libloading, but the one for musl hosts was never adjusted accordingly.
…rect See the MIPS N64 ABI specification: https://web.archive.org/web/20160121005457/http://techpubs.sgi.com/library/manuals/2000/007-2816-005/pdf/007-2816-005.pdf#page=25 The examples make clear why this is the correct behavior and not just a GCC-ism that we're replicating.
…r=tgross35 test-float-parse: Share one table of powers of two sized for f64 Constants::new() built a table of 2^n for every n in -(2 << 15)..=(2 << 15), plus a second table of 2^(n-1) for half_ulp, separately for each float type. The size of 2^n grows with |n|, so each table took 512 MiB. The unit tests use f32 and f64 and peak at 2.1 GiB, which gets them OOM-killed on test-armhf-gnu's 1 GiB qemu machine. Keep a single table shared by all float types, covering only the exponents decode() can produce for f64, and look up half a ULP as the next power of two down instead of keeping a second table. The unit tests now peak at 15 MiB. Found when investigating the CI failure in rust-lang#162934
…ackh726
[tiny] Show trait span for associated item with similar name
```
help: there is a method `bag` with a similar name, but with different arguments
--> $DIR/suggest-methods.rs:9:5
|
LL | trait FooT {
LL | fn bag(&self);
| ^^^^^^^^^^^^^^
```
deduced_param_attrs for unit type offers no benefit Outputs, where unit type is implicit default, did participate in the deduction. Identify unit type as irrelevant for the deduction as an optimization.
…iagnostics, r=mejrs fix misleading diagnostics and improve diagnostics of return type mismatch Fix misleading diagnostics and improve diagnostics of return type mismatch - Fixed misleading suggestions of adding a return and semicolon expression to an expression already in return position by adding a return position check. - Fixed duplicate emission of error 277 by de-duplicateing the suggestion `suggest_missing_break_or_return_expr`, where a failed normalization leads to E277 fixes: rust-lang#162271
…hite set aliases in closure error bodies to rigid with next-solver We already do this in the `DefKind::Closure` arm of `construct_fn`, and not doing so would cause us to ICE, such as in the test. r? project-trait-system-refactor
…tests, r=Urgau More `tests/rustdoc-html` cleanups Another cleanup. :) r? @Urgau
…olkertdev callconv: mips64: Clarify why padding floats with integer args is correct See the MIPS N64 ABI specification: https://web.archive.org/web/20160121005457/http://techpubs.sgi.com/library/manuals/2000/007-2816-005/pdf/007-2816-005.pdf#page=25 The examples make clear why this is the correct behavior and not just a GCC-ism that we're replicating. r? folkertdev
…-musl-libloading-0.9, r=folkertdev tests: Update duplicated-path-in-error message on musl hosts The error messages produced by libloading 0.9 are different than those of libloading 0.8. The error message expected for GNU hosts changed in the same fashion and was updated in 7672b83 alongside libloading, but the one for musl hosts was never adjusted accordingly.
rustbot
added
S-waiting-on-review
Member
Author
|
@bors r+ p=5 force |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
merged-by-bors
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 6f5da40 (parent) -> 7211ea5 (this PR) Test differencesShow 118 test diffsStage 1
Stage 2
Additionally, 36 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 7211ea594cbf137ef6118b1752b959dea7cb9088 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (7211ea5): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -1.4%, secondary -1.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -2.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 488.596s -> 492.622s (0.82%) |
Contributor
|
📌 Perf builds for each rolled up PR:
parent commit: 6f5da406b5 In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
tests/rustdoc-htmlcleanups #164100 (Moretests/rustdoc-htmlcleanups)r? @ghost
Create a similar rollup