Repository navigation
deduced_param_attrs for unit type offers no benefit - #164020
Merged
Merged
Conversation
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @jackh726 rustbot has assigned @jackh726. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
Bot
force-pushed
the
deduce-unit
branch
from
October 9, 2026 07:10
b177183 to
515d670
Compare
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-review
jackh726
approved these changes
Oct 9, 2026
rust-cloud-vms
Bot
force-pushed
the
deduce-unit
branch
from
October 10, 2026 08:54
515d670 to
63e0623
Compare
tmiasko
changed the title
Outputs, where unit type is implicit default, did participate in the deduction. Identify unit type as irrelevant for the deduction as an optimization.
rust-cloud-vms
Bot
force-pushed
the
deduce-unit
branch
from
October 10, 2026 08:59
63e0623 to
ae95e71
Compare
Member
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 11, 2026
Rollup of 8 pull requests Successful merges: - #163402 (test-float-parse: Share one table of powers of two sized for f64) - #163999 ([tiny] Show trait span for associated item with similar name) - #164020 (deduced_param_attrs for unit type offers no benefit) - #162926 (fix misleading diagnostics and improve diagnostics of return type mismatch) - #164075 (set aliases in closure error bodies to rigid with next-solver) - #164100 (More `tests/rustdoc-html` cleanups) - #164110 (callconv: mips64: Clarify why padding floats with integer args is correct) - #164120 (tests: Update duplicated-path-in-error message on musl hosts)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 11, 2026
Rollup merge of #164020 - tmiasko:deduce-unit, r=jackh726 deduced_param_attrs for unit type offers no benefit Outputs, where unit type is implicit default, did participate in the deduction. Identify unit type as irrelevant for the deduction as an optimization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outputs, where unit type is implicit default, did participate in the deduction. Identify unit type as irrelevant for the deduction as an optimization.