Skip to content

disable next-solver with higher-ranked-assumptions - #163949

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
lcnr:higher-ranked-assumptions-yeet
Oct 8, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
lcnr:higher-ranked-assumptions-yeet

Conversation

@lcnr

@lcnr lcnr commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

that's nicer than needing to update all the [assumptions] ui tests I think

r? @lqd or @BoxyUwU

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 7, 2026
@rustbot

rustbot commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

lqd is not on the review rotation at the moment.
They may take a while to respond.

}

fn warn_next_solver_and_higher_ranked_assumptions(sess: &Session) {
// Warn people who uses GCE and -Znext-solver=globally

@lqd lqd Oct 7, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Warn people who uses GCE and -Znext-solver=globally
// Warn people who use -Zhigher-ranked-assumptions and -Znext-solver=globally

View changes since the review

Comment thread compiler/rustc_ast_passes/src/feature_gate.rs Outdated

@lqd lqd left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me as well, r=me

View changes since this review

@rust-log-analyzer

This comment has been minimized.

@lcnr
lcnr force-pushed the higher-ranked-assumptions-yeet branch 3 times, most recently from 21f0173 to 3f6c23c Compare October 7, 2026 15:38
@rust-log-analyzer

This comment has been minimized.

Comment thread compiler/rustc_ast_passes/src/diagnostics.rs Outdated
Comment thread compiler/rustc_ast_passes/src/feature_gate.rs Outdated
Comment thread tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-1.rs Outdated
@lcnr
lcnr force-pushed the higher-ranked-assumptions-yeet branch from 3f6c23c to 7870b60 Compare October 7, 2026 16:36
@lcnr

lcnr commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

@bors r=lqd rollup

@rust-bors

rust-bors Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 7870b60 has been tentatively approved by lqd

It will be put into the queue for this repository once PR CI succeeds.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 7, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Oct 8, 2026
…t, r=lqd

disable next-solver with higher-ranked-assumptions

that's nicer than needing to update all the `[assumptions]` ui tests I think

r? @lqd or @BoxyUwU
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 8, 2026
…t, r=lqd

disable next-solver with higher-ranked-assumptions

that's nicer than needing to update all the `[assumptions]` ui tests I think

r? @lqd or @BoxyUwU
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 8, 2026
…t, r=lqd

disable next-solver with higher-ranked-assumptions

that's nicer than needing to update all the `[assumptions]` ui tests I think

r? @lqd or @BoxyUwU
rust-bors Bot pushed a commit that referenced this pull request Oct 8, 2026
…uwer

Rollup of 10 pull requests

Successful merges:

 - #162741 (codegen: tell LLVM that the discriminant is a power of two)
 - #162758 (Split PassMode::IndirectUnsized out of PassMode::Indirect)
 - #163931 (Move `loop_hint_attrs` from `Terminator` into `TerminatorKind::Goto`)
 - #163028 (autodiff: fix sysroot candidates in libEnzyme not found error)
 - #163538 (Add `rustc::missing_generic_type_visitable` lint)
 - #163841 ([rustdoc] Fix more `incoherent_impl` linking)
 - #163908 (Update Enzyme submodule)
 - #163935 (Use BasicBlock::start_location and Location::START)
 - #163949 (disable next-solver with higher-ranked-assumptions)
 - #163951 (relax_elf_relocations is x86-only)
rust-bors Bot pushed a commit that referenced this pull request Oct 8, 2026
…uwer

Rollup of 11 pull requests

Successful merges:

 - #162741 (codegen: tell LLVM that the discriminant is a power of two)
 - #162758 (Split PassMode::IndirectUnsized out of PassMode::Indirect)
 - #163931 (Move `loop_hint_attrs` from `Terminator` into `TerminatorKind::Goto`)
 - #163028 (autodiff: fix sysroot candidates in libEnzyme not found error)
 - #163257 (abby DSL: sanity checks on forall where clauses)
 - #163841 ([rustdoc] Fix more `incoherent_impl` linking)
 - #163908 (Update Enzyme submodule)
 - #163935 (Use BasicBlock::start_location and Location::START)
 - #163949 (disable next-solver with higher-ranked-assumptions)
 - #163951 (relax_elf_relocations is x86-only)
 - #163968 (Remove needs-triage label from relnotes issues)
@rust-bors
rust-bors Bot merged commit a0e7eb5 into rust-lang:main Oct 8, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 8, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 8, 2026
Rollup merge of #163949 - lcnr:higher-ranked-assumptions-yeet, r=lqd

disable next-solver with higher-ranked-assumptions

that's nicer than needing to update all the `[assumptions]` ui tests I think

r? @lqd or @BoxyUwU
@lcnr
lcnr deleted the higher-ranked-assumptions-yeet branch October 8, 2026 13:37
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Oct 9, 2026
…uwer

Rollup of 11 pull requests

Successful merges:

 - rust-lang/rust#162741 (codegen: tell LLVM that the discriminant is a power of two)
 - rust-lang/rust#162758 (Split PassMode::IndirectUnsized out of PassMode::Indirect)
 - rust-lang/rust#163931 (Move `loop_hint_attrs` from `Terminator` into `TerminatorKind::Goto`)
 - rust-lang/rust#163028 (autodiff: fix sysroot candidates in libEnzyme not found error)
 - rust-lang/rust#163257 (abby DSL: sanity checks on forall where clauses)
 - rust-lang/rust#163841 ([rustdoc] Fix more `incoherent_impl` linking)
 - rust-lang/rust#163908 (Update Enzyme submodule)
 - rust-lang/rust#163935 (Use BasicBlock::start_location and Location::START)
 - rust-lang/rust#163949 (disable next-solver with higher-ranked-assumptions)
 - rust-lang/rust#163951 (relax_elf_relocations is x86-only)
 - rust-lang/rust#163968 (Remove needs-triage label from relnotes issues)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants