Repository navigation
[rustdoc] Fix more incoherent_impl linking - #163841
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
Member
Author
|
Ah right, github CI is down. |
Member
Author
|
CI passed. |
Urgau
approved these changes
Oct 7, 2026
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Oct 8, 2026
…Urgau [rustdoc] Fix more `incoherent_impl` linking Hopefully last fix for rust-lang#162808. We force the correct crate to be linked when generating the external location based on the `DefId` crate. I'm actually surprised it wasn't an issue before. Oh well. r? @Urgau
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 8, 2026
…Urgau [rustdoc] Fix more `incoherent_impl` linking Hopefully last fix for rust-lang#162808. We force the correct crate to be linked when generating the external location based on the `DefId` crate. I'm actually surprised it wasn't an issue before. Oh well. r? @Urgau
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 8, 2026
…Urgau [rustdoc] Fix more `incoherent_impl` linking Hopefully last fix for rust-lang#162808. We force the correct crate to be linked when generating the external location based on the `DefId` crate. I'm actually surprised it wasn't an issue before. Oh well. r? @Urgau
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 8, 2026
…uwer Rollup of 10 pull requests Successful merges: - #162741 (codegen: tell LLVM that the discriminant is a power of two) - #162758 (Split PassMode::IndirectUnsized out of PassMode::Indirect) - #163931 (Move `loop_hint_attrs` from `Terminator` into `TerminatorKind::Goto`) - #163028 (autodiff: fix sysroot candidates in libEnzyme not found error) - #163538 (Add `rustc::missing_generic_type_visitable` lint) - #163841 ([rustdoc] Fix more `incoherent_impl` linking) - #163908 (Update Enzyme submodule) - #163935 (Use BasicBlock::start_location and Location::START) - #163949 (disable next-solver with higher-ranked-assumptions) - #163951 (relax_elf_relocations is x86-only)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 8, 2026
…uwer Rollup of 11 pull requests Successful merges: - #162741 (codegen: tell LLVM that the discriminant is a power of two) - #162758 (Split PassMode::IndirectUnsized out of PassMode::Indirect) - #163931 (Move `loop_hint_attrs` from `Terminator` into `TerminatorKind::Goto`) - #163028 (autodiff: fix sysroot candidates in libEnzyme not found error) - #163257 (abby DSL: sanity checks on forall where clauses) - #163841 ([rustdoc] Fix more `incoherent_impl` linking) - #163908 (Update Enzyme submodule) - #163935 (Use BasicBlock::start_location and Location::START) - #163949 (disable next-solver with higher-ranked-assumptions) - #163951 (relax_elf_relocations is x86-only) - #163968 (Remove needs-triage label from relnotes issues)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 8, 2026
Rollup merge of #163841 - GuillaumeGomez:incoherent-impl, r=Urgau [rustdoc] Fix more `incoherent_impl` linking Hopefully last fix for #162808. We force the correct crate to be linked when generating the external location based on the `DefId` crate. I'm actually surprised it wasn't an issue before. Oh well. r? @Urgau
makai410
pushed a commit
to makai410/rustc_public
that referenced
this pull request
Oct 9, 2026
…uwer Rollup of 11 pull requests Successful merges: - rust-lang/rust#162741 (codegen: tell LLVM that the discriminant is a power of two) - rust-lang/rust#162758 (Split PassMode::IndirectUnsized out of PassMode::Indirect) - rust-lang/rust#163931 (Move `loop_hint_attrs` from `Terminator` into `TerminatorKind::Goto`) - rust-lang/rust#163028 (autodiff: fix sysroot candidates in libEnzyme not found error) - rust-lang/rust#163257 (abby DSL: sanity checks on forall where clauses) - rust-lang/rust#163841 ([rustdoc] Fix more `incoherent_impl` linking) - rust-lang/rust#163908 (Update Enzyme submodule) - rust-lang/rust#163935 (Use BasicBlock::start_location and Location::START) - rust-lang/rust#163949 (disable next-solver with higher-ranked-assumptions) - rust-lang/rust#163951 (relax_elf_relocations is x86-only) - rust-lang/rust#163968 (Remove needs-triage label from relnotes issues)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully last fix for #162808.
We force the correct crate to be linked when generating the external location based on the
DefIdcrate. I'm actually surprised it wasn't an issue before. Oh well.r? @Urgau