Skip to content

Rollup of 11 pull requests - #163829

Merged
rust-bors[bot] merged 35 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-8dFIE96
Oct 5, 2026
Merged

rust-bors[bot] merged 35 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-8dFIE96

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

RalfJung and others added 30 commits September 26, 2026 08:44
…ps, r=mati865

make semicolon_in_expressions_from_non_local_macros not report-in-deps

See rust-lang#162872 for context. This new lint was made immediately report-in-deps without a crater run. I guess people assumed that the ecosystem fallout would be small, but no data was gathered to confirm that hypothesis. We now have data showing that the ecosystem fallout is [gigantic](rust-lang#162768 (comment)), so let's remove the report-in-deps from this lint.

This should be backported to the 1.100 beta. (1.99 already has this patch.)

Cc @joshtriplett
…, r=petrochenkov

rustc_ast_lowering: track implicit Self via explicit flag instead of name

fixes rust-lang#163457
& added a ui regression test for the reported reproducer.

r? @bjorn3
…li-obk

document the rustc_comptime attribute

r? @oli-obk
Skip optional asserts in SsaRangePropagation

Fixes rust-lang#163779.

Is it normal to have a mir-opt diff without any diff in it? I think it communicates what I want in this case, that the pass does nothing to this code.
Bump Windows CI LLVM to 22.1.8

It's fallen a bit behind the linux runners. Also needed for running `tests/debuginfo` on windows CI runners (rust-lang#163090)
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Oct 5, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member Author

@bors r+ p=5 force

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,test-x86_64-gnu-aux,test-x86_64-msvc-1,test-aarch64-apple-1,test-aarch64-apple-2,test-x86_64-mingw-1,test-i686-msvc,test-armhf-gnu

@rust-bors

rust-bors Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 45e8c52 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Oct 5, 2026
Rollup of 11 pull requests


try-job: dist-various-1
try-job: test-various
try-job: test-x86_64-gnu-aux
try-job: test-x86_64-msvc-1
try-job: test-aarch64-apple-1
try-job: test-aarch64-apple-2
try-job: test-x86_64-mingw-1
try-job: test-i686-msvc
try-job: test-armhf-gnu
@rust-bors

This comment has been minimized.

@rust-bors

rust-bors Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: e078317 (e078317a3fd5ebd40555a5372d7388a81177c082)
Base parent: 602727f (602727f26878dcf9eb2999e2f58e5df1269ff47e)

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 5, 2026
@rust-bors

rust-bors Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 2h 55m 18s
Pushing ea13733 to main...

@rust-bors
rust-bors Bot merged commit ea13733 into rust-lang:main Oct 5, 2026
16 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 5, 2026
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 602727f (parent) -> ea13733 (this PR)

Test differences

Show 375 test diffs

Stage 1

  • [ui] tests/ui/associated-types/higher-ranked/incomplete-hr-alias-relate-ICE.rs#next: [missing] -> pass (J0)
  • [ui] tests/ui/async-await/higher-ranked-auto-trait-11.rs#assumptions: pass -> [missing] (J0)
  • [ui] tests/ui/async-await/higher-ranked-auto-trait-12.rs#assumptions: pass -> [missing] (J0)
  • [ui] tests/ui/async-await/higher-ranked-auto-trait-15.rs#assumptions: pass -> [missing] (J0)
  • [ui] tests/ui/async-await/higher-ranked-auto-trait-17.rs#assumptions: pass -> [missing] (J0)
  • [ui] tests/ui/async-await/higher-ranked-auto-trait-18.rs#assumptions: pass -> [missing] (J0)
  • [ui] tests/ui/async-await/higher-ranked-auto-trait-3.rs#assumptions: pass -> [missing] (J0)
  • [ui] tests/ui/async-await/higher-ranked-auto-trait-6.rs#no_assumptions: pass -> [missing] (J0)
  • [ui] tests/ui/async-await/higher-ranked-auto-trait-7.rs#no_assumptions: pass -> [missing] (J0)
  • [ui] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-14.rs#assumptions: [missing] -> pass (J0)
  • [ui] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-14.rs#no_assumptions: [missing] -> pass (J0)
  • [ui] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-15.rs#assumptions: [missing] -> pass (J0)
  • [ui] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-16.rs#no_assumptions: [missing] -> pass (J0)
  • [ui] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-2.rs#assumptions: [missing] -> pass (J0)
  • [ui] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-5.rs#assumptions: [missing] -> pass (J0)
  • [ui] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-6.rs#no_assumptions: [missing] -> pass (J0)
  • [ui] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-7.rs#no_assumptions: [missing] -> pass (J0)
  • [ui] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-8.rs#assumptions: [missing] -> pass (J0)
  • [ui] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-8.rs#no_assumptions: [missing] -> pass (J0)
  • [ui] tests/ui/async-await/witness-auto-trait/witness-lifetime-dependent-auto-trait-119095.rs#old: [missing] -> pass (J0)
  • [ui] tests/ui/coherence/dyn-trait-overlap/pr-review-132289-2.rs#next: [missing] -> pass (J0)
  • [ui] tests/ui/coherence/pr-review-132289-1.rs: pass -> [missing] (J0)
  • [ui] tests/ui/higher-ranked/leak-check/old-solver-only-leak-check-on-ambig.rs#next: [missing] -> pass (J0)
  • [ui] tests/ui/impl-trait/closures/in-closure-capture-ice-119786-2.rs#next: [missing] -> pass (J0)
  • [ui] tests/ui/impl-trait/closures/in-closure-capture-ice-119786-3.rs#next: [missing] -> pass (J0)
  • [ui] tests/ui/impl-trait/issues/relate-mir-borrowck-ice-117392.rs#next: [missing] -> pass (J0)
  • [ui] tests/ui/specialization/min_specialization/unexpected-infer-var-ice-102252-2.rs#old: [missing] -> pass (J0)
  • [ui] tests/ui/traits/projection-cache-rematch-impl-122529.rs#next: [missing] -> pass (J0)
  • [ui] tests/ui/type-inference/snapshot-infer-leakage/leak-infer-ice-120254.rs#next: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/async-await/higher-ranked-auto-trait-1.rs#assumptions: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/async-await/higher-ranked-auto-trait-11.rs#assumptions: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/async-await/higher-ranked-auto-trait-12.rs#no_assumptions: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/async-await/higher-ranked-auto-trait-13.rs#no_assumptions: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/async-await/higher-ranked-auto-trait-17.rs#no_assumptions: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/async-await/higher-ranked-auto-trait-18.rs#assumptions: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/async-await/higher-ranked-auto-trait-18.rs#no_assumptions: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/async-await/higher-ranked-auto-trait-3.rs#assumptions: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/async-await/higher-ranked-auto-trait-4.rs#no_assumptions: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/async-await/higher-ranked-auto-trait-6.rs#no_assumptions: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/async-await/higher-ranked-auto-trait-8.rs#no_assumptions: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/async-await/higher-ranked-auto-trait-9.rs#assumptions: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-10.rs#assumptions: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-11.rs#no_assumptions: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-12.rs#assumptions: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-12.rs#no_assumptions: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-13.rs#no_assumptions: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-14.rs#assumptions: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-15.rs#assumptions: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-16.rs#assumptions: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-16.rs#no_assumptions: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-17.rs#no_assumptions: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-18.rs#no_assumptions: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-2.rs#no_assumptions: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-3.rs#no_assumptions: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/attributes/doc_examples/rustc_comptime.rs: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/coherence/pr-review-132289-1.rs: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/higher-ranked/leak-check/old-solver-only-leak-check-on-ambig-closure-sig.rs#next: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/impl-trait/closures/in-closure-capture-ice-119786-1.rs#next: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/impl-trait/closures/in-closure-capture-ice-119786-3.rs#next: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/impl-trait/closures/in-closure-capture-ice-119786-3.rs#old: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/impl-trait/issues/relate-mir-borrowck-ice-117392.rs#next: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/specialization/min_specialization/unexpected-infer-var-ice-102252-2.rs#old: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/traits/next-solver/diagnostics/overflowing-opaque-incorrectly-unconstrained.rs: [missing] -> pass (J1)
  • [crashes] tests/crashes/102047.rs: pass -> [missing] (J4)
  • [crashes] tests/crashes/115435.rs: pass -> [missing] (J4)
  • [crashes] tests/crashes/117392.rs: pass -> [missing] (J4)
  • [crashes] tests/crashes/126667.rs: pass -> [missing] (J4)

Stage 2

  • [ui] tests/ui/associated-types/higher-ranked/incomplete-hr-alias-relate-ICE.rs#next: [missing] -> pass (J2)
  • [ui] tests/ui/async-await/higher-ranked-auto-trait-10.rs#assumptions: pass -> [missing] (J2)
  • [ui] tests/ui/async-await/higher-ranked-auto-trait-11.rs#assumptions: pass -> [missing] (J2)
  • [ui] tests/ui/async-await/higher-ranked-auto-trait-13.rs#no_assumptions: pass -> [missing] (J2)
  • [ui] tests/ui/async-await/higher-ranked-auto-trait-15.rs#assumptions: pass -> [missing] (J2)
  • [ui] tests/ui/async-await/higher-ranked-auto-trait-16.rs#no_assumptions: pass -> [missing] (J2)
  • [ui] tests/ui/async-await/higher-ranked-auto-trait-3.rs#assumptions: pass -> [missing] (J2)
  • [ui] tests/ui/async-await/higher-ranked-auto-trait-3.rs#no_assumptions: pass -> [missing] (J2)
  • [ui] tests/ui/async-await/higher-ranked-auto-trait-5.rs#assumptions: pass -> [missing] (J2)
  • [ui] tests/ui/async-await/higher-ranked-auto-trait-6.rs#no_assumptions: pass -> [missing] (J2)
  • [ui] tests/ui/async-await/higher-ranked-auto-trait-7.rs#no_assumptions: pass -> [missing] (J2)
  • [ui] tests/ui/async-await/higher-ranked-auto-trait-8.rs#assumptions: pass -> [missing] (J2)
  • [ui] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-12.rs#no_assumptions: [missing] -> pass (J2)
  • [ui] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-14.rs#assumptions: [missing] -> pass (J2)
  • [ui] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-16.rs#no_assumptions: [missing] -> pass (J2)
  • [ui] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-3.rs#no_assumptions: [missing] -> pass (J2)
  • [ui] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-6.rs#no_assumptions: [missing] -> pass (J2)
  • [ui] tests/ui/async-await/witness-auto-trait/higher-ranked-auto-trait-8.rs#assumptions: [missing] -> pass (J2)
  • [ui] tests/ui/coherence/dyn-trait-overlap/pr-review-132289-2.rs#old: [missing] -> pass (J2)
  • [ui] tests/ui/coherence/dyn-trait-overlap/pr-review-132289-3.rs#next: [missing] -> pass (J2)
  • [ui] tests/ui/coherence/dyn-trait-overlap/pr-review-132289-3.rs#old: [missing] -> pass (J2)
  • [ui] tests/ui/coherence/dyn-trait-overlap/size_of-assumes-sized-115435.rs#next: [missing] -> pass (J2)
  • [ui] tests/ui/higher-ranked/leak-check/old-solver-only-leak-check-on-ambig.rs#old: [missing] -> pass (J2)
  • [ui] tests/ui/impl-trait/closures/in-closure-capture-ice-119786-1.rs#old: [missing] -> pass (J2)
  • [ui] tests/ui/impl-trait/closures/in-closure-capture-ice-119786-2.rs#next: [missing] -> pass (J2)
  • [ui] tests/ui/impl-trait/closures/in-closure-capture-ice-119786-2.rs#old: [missing] -> pass (J2)
  • [ui] tests/ui/impl-trait/closures/in-closure-capture-ice-119786-3.rs#old: [missing] -> pass (J2)
  • [ui] tests/ui/traits/next-solver/diagnostics/overflowing-opaque-incorrectly-unconstrained.rs: [missing] -> pass (J2)
  • [crashes] tests/crashes/102252.rs: pass -> [missing] (J3)
  • [crashes] tests/crashes/115435.rs: pass -> [missing] (J3)
  • [crashes] tests/crashes/119786-1.rs: pass -> [missing] (J3)
  • [crashes] tests/crashes/120254.rs: pass -> [missing] (J3)
  • [crashes] tests/crashes/124440.rs: pass -> [missing] (J3)

(and 270 additional test diffs)

Additionally, 5 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard ea137335b78829b4514bf1b4c16302f74fab8581 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. test-x86_64-gnu-llvm-22-2: 1h 10m -> 1h 45m (+50.3%)
  2. test-aarch64-apple-1: 1h 30m -> 2h 15m (+49.9%)
  3. dist-ohos-aarch64: 54m 7s -> 1h 19m (+46.4%)
  4. optional-test-x86_64-gnu-autodiff: 37m 26s -> 54m 18s (+45.1%)
  5. test-x86_64-rust-for-linux: 42m 49s -> 1h (+42.3%)
  6. test-x86_64-gnu-nopt: 2h 28m -> 1h 25m (-42.0%)
  7. test-i686-msvc: 1h 54m -> 2h 38m (+38.8%)
  8. test-x86_64-gnu-miri: 1h 6m -> 1h 32m (+38.8%)
  9. dist-android: 22m 59s -> 31m 54s (+38.8%)
  10. test-i686-gnu-1: 2h 29m -> 1h 32m (-37.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (ea13733): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (primary 1.2%, secondary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.5% [2.2%, 2.9%] 3
Regressions ❌
(secondary)
2.9% [2.9%, 2.9%] 1
Improvements ✅
(primary)
-2.7% [-2.7%, -2.7%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.2% [-2.7%, 2.9%] 4

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 490.152s -> 496.563s (1.31%)
Artifact size: 408.63 MiB -> 408.58 MiB (-0.01%)

@rust-bors

rust-bors Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#163364 make semicolon_in_expressions_from_non_local_macros not rep… 98e3dc8f1dce45a156b80bd3218a5ff6b9afa99c
(link)
#163531 rustc_ast_lowering: track implicit Self via explicit flag i… f1e331e69d5356290e2a84687cab164611b54e87
(link)
#163770 document the rustc_comptime attribute df48476f046d80c84a6517bbd88e8ba75e52481d
(link)
#163780 Skip optional asserts in SsaRangePropagation b022ddc851e88cdb26c285aea30d038fcd4e64cf
(link)
#163785 Bump Windows CI LLVM to 22.1.8 59ef08d3ac636437532224809fc2409d3159f7ce
(link)
#163796 continue crashes tests -Znext-solver work 6f0779e325eded3027a8c28d68746b453473b498
(link)
#163646 Get inputs_hir directly from decl 5552cb9dfb1139b1c31501ca4bc71a91e59ba15c
(link)
#163733 Fix extra spaces in integer format_into docs f7cd4768591b6e22b586196fe20295ef5e894f3a
(link)
#163773 Update GitHub Actions to v26 657dce1b81dccf6305f7da720adbd46d39d7cae2
(link)
#163787 moves rustc_legacy_const_generics checks into attribute par… f3d89a67fe3890da493323e5e0e593cce07939a6
(link)
#163810 Fix an issue for clippy's search_is_some with the next-so… f55065f7ed3715d321d198b551bec47de3e41bc9
(link)

parent commit: 602727f268

In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: @rust-timer triage $SHA $SHA $SHA..., or run @rust-timer triage all to benchmark all rollup members.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.